Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dist/types #316

Merged
merged 3 commits into from
Apr 9, 2024
Merged

fix: dist/types #316

merged 3 commits into from
Apr 9, 2024

Conversation

k0stik
Copy link
Member

@k0stik k0stik commented Apr 9, 2024 •
edited
Loading

I this PR I moved dist/js/types.ts to src/js/types.ts. After transpiling it became dist/js/types.js and dist/js/types.d.ts.
I also added src/js/types.ts to .gitignore as we need it only once before transpilation

VsevolodX
VsevolodX approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@VsevolodX VsevolodX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k0stik k0stik merged commit 92e2896 into dev Apr 9, 2024
13 checks passed
@k0stik k0stik deleted the fix/types branch April 9, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VsevolodX VsevolodX VsevolodX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k0stik @VsevolodX