Feature/SOF-7287 feature: add JL drawer to MD #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mat3ra-materials-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| componentDidMount() { | ||
| this.messageHandler.addHandlers("set-data", [this.handleSetMaterials]); | ||
| this.messageHandler.addHandlers("get-data", [this.returnSelectedMaterials]); |
There was a problem hiding this comment.
Seems like code duplicate Let's reuse this through a parent
There was a problem hiding this comment.
Added base and inheritance
| }); | ||
| } | ||
| } | ||
| exports.SAlertWidget = SAlertWidget; |
There was a problem hiding this comment.
Wtf are all these extra files???
There was a problem hiding this comment.
They came from commiting dist
| <div style={{ display: show ? "block" : "none" }}> | ||
| <ResizableDrawer open={show} onClose={onHide} containerRef={containerRef}> | ||
| <JupyterLiteSession | ||
| originURL="https://jupyterlite.mat3ra.com" |
There was a problem hiding this comment.
Remove originURL
defaultNotebook should be set in Base
messageHandler should be created inside Base
| @@ -162,7 +83,7 @@ class JupyterLiteTransformation extends React.Component< | |||
| }} | |||
| > | |||
| <JupyterLiteSession | |||
| defaultNotebookPath={DEFAULT_NOTEBOOK_PATH} | |||
| defaultNotebookPath={this.DEFAULT_NOTEBOOK_PATH} | |||
timurbazhirov
approved these changes
Apr 2, 2024
…signer into feature/SOF-7287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.