Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Commit

Permalink
Merge pull request #1189 from interactivellama/remove-hide
Browse files Browse the repository at this point in the history 
Replace `hide` class with `hidden`
  • Loading branch information
@chriscorwin
chriscorwin committed Mar 25, 2015
2 parents 7c299f6 + 51bf3a6 commit f9e5c9b
Show file tree
Hide file tree
Showing 13 changed files with 75 additions and 73 deletions.
34 changes: 17 additions & 17 deletions index.html
View file
Expand Up @@ -107,9 +107,9 @@ <h2>Checkboxes</h2>
<span class="checkbox-label">Custom checkbox toggles by id</span>
</label>
</div>
<div aria-hidden="true" class="checkboxToggle alert alert-warning hide">This message's visibility toggles by class with a checkbox above.</div>
<div aria-hidden="true" class="checkboxToggle alert alert-success hide">This message's visibility toggles by class with a checkbox above.</div>
<div aria-hidden="true" class="alert alert-info hide" id="checkboxToggle">This message's visibility toggles by id with a checkbox above.</div>
<div aria-hidden="true" class="checkboxToggle alert alert-warning hidden">This message's visibility toggles by class with a checkbox above.</div>
<div aria-hidden="true" class="checkboxToggle alert alert-success hidden">This message's visibility toggles by class with a checkbox above.</div>
<div aria-hidden="true" class="alert alert-info hidden" id="checkboxToggle">This message's visibility toggles by id with a checkbox above.</div>
</section>
<section id="checkboxes-highlighting-block">
<div class="checkbox highlight">
Expand Down Expand Up @@ -742,9 +742,9 @@ <h2>Radio Buttons</h2>
</label>
</div>

<div aria-hidden="true" class="radioToggle alert alert-warning hide">This message's visibility toggles by class with a radio above.</div>
<div aria-hidden="true" class="radioToggle alert alert-success hide">This message's visibility toggles by class with a radio above.</div>
<div aria-hidden="true" class="alert alert-info hide" id="radioToggle">This message's visibility toggles by id with a radio above.</div>
<div aria-hidden="true" class="radioToggle alert alert-warning hidden">This message's visibility toggles by class with a radio above.</div>
<div aria-hidden="true" class="radioToggle alert alert-success hidden">This message's visibility toggles by class with a radio above.</div>
<div aria-hidden="true" class="alert alert-info hidden" id="radioToggle">This message's visibility toggles by id with a radio above.</div>

<br/>
<!--Highlight capability-->
Expand Down Expand Up @@ -1572,7 +1572,7 @@ <h2 class="header">Year</h2>
<input type="text" aria-hidden="true" readonly="readonly" name="intervalSelectlist" class="hidden hidden-field">
</div>

<div class="repeat-panel repeat-every-panel repeat-hourly repeat-daily repeat-weekly hide" aria-hidden="true">
<div class="repeat-panel repeat-every-panel repeat-hourly repeat-daily repeat-weekly hidden" aria-hidden="true">
<label id="MySchedulerEveryLabel" class="inline-form-text repeat-every-pretext">every</label>

<div class="spinbox digits-3 repeat-every">
Expand All @@ -1591,7 +1591,7 @@ <h2 class="header">Year</h2>
</div>
</div>

<div class="form-group repeat-panel repeat-weekly repeat-days-of-the-week hide" aria-hidden="true">
<div class="form-group repeat-panel repeat-weekly repeat-days-of-the-week hidden" aria-hidden="true">
<fieldset class="btn-group" data-toggle="buttons">
<label class="btn btn-default">
<input type="checkbox" data-value="SU">Sun
Expand All @@ -1617,7 +1617,7 @@ <h2 class="header">Year</h2>
</fieldset>
</div>

<div class="repeat-panel repeat-monthly hide" aria-hidden="true">
<div class="repeat-panel repeat-monthly hidden" aria-hidden="true">
<div class="form-group repeat-monthly-date">
<div class="radio pull-left">
<label class="radio-custom">
Expand Down Expand Up @@ -1757,7 +1757,7 @@ <h2 class="header">Year</h2>
</div>
</div>

<div class="repeat-panel repeat-yearly hide" aria-hidden="true">
<div class="repeat-panel repeat-yearly hidden" aria-hidden="true">
<div class="form-group repeat-yearly-date">
<div class="radio pull-left">
<label class="radio-custom">
Expand Down Expand Up @@ -1968,7 +1968,7 @@ <h2 class="header">Year</h2>
</div>
</div>

<div class="form-group repeat-end hide" aria-hidden="true">
<div class="form-group repeat-end hidden" aria-hidden="true">
<label class="col-sm-2 control-label scheduler-label">End</label>
<div class="col-sm-10 row">
<div class="col-sm-3 form-group">
Expand All @@ -1990,7 +1990,7 @@ <h2 class="header">Year</h2>
</div>
</div>

<div class="col-sm-6 form-group end-option-panel end-after-panel pull-left hide" aria-hidden="true">
<div class="col-sm-6 form-group end-option-panel end-after-panel pull-left hidden" aria-hidden="true">
<div class="spinbox digits-3 end-after">
<label id="MyEndAfter" class="sr-only">End After</label>
<input type="text" class="form-control input-mini spinbox-input" aria-labelledby="MyEndAfter">
Expand All @@ -2006,7 +2006,7 @@ <h2 class="header">Year</h2>
<div class="inline-form-text end-after-text">occurance(s)</div>
</div>

<div class="col-sm-8 form-group end-option-panel end-on-date-panel pull-left hide" aria-hidden="true">
<div class="col-sm-8 form-group end-option-panel end-on-date-panel pull-left hidden" aria-hidden="true">
<div class="datepicker input-group end-on-date">
<div class="input-group">
<input class="form-control" type="text" />
Expand Down Expand Up @@ -2223,7 +2223,7 @@ <h2>Spinbox</h2>
<h2>Tree</h2>
<div class="thin-box">
<ul class="tree" id="myTree1" role="tree">
<li class="tree-branch hide" data-template="treebranch" role="treeitem" aria-expanded="false">
<li class="tree-branch hidden" data-template="treebranch" role="treeitem" aria-expanded="false">
<div class="tree-branch-header">
<button class="tree-branch-name">
<span class="glyphicon icon-caret glyphicon-play"></span>
Expand All @@ -2234,7 +2234,7 @@ <h2>Tree</h2>
<ul class="tree-branch-children" role="group"></ul>
<div class="tree-loader" role="alert">Loading...</div>
</li>
<li class="tree-item hide" data-template="treeitem" role="treeitem">
<li class="tree-item hidden" data-template="treeitem" role="treeitem">
<button class="tree-item-name">
<span class="glyphicon icon-item fueluxicon-bullet"></span>
<span class="tree-label"></span>
Expand All @@ -2243,7 +2243,7 @@ <h2>Tree</h2>
</ul>

<ul class="tree tree-folder-select" id="myTree2" role="tree">
<li class="tree-branch hide" data-template="treebranch" role="treeitem" aria-expanded="false">
<li class="tree-branch hidden" data-template="treebranch" role="treeitem" aria-expanded="false">
<div class="tree-branch-header">
<button class="glyphicon icon-caret glyphicon-play"><span class="sr-only">Open</span>
</button>
Expand All @@ -2255,7 +2255,7 @@ <h2>Tree</h2>
<ul class="tree-branch-children" role="group"></ul>
<div class="tree-loader" role="alert">Loading...</div>
</li>
<li class="tree-item hide" data-template="treeitem" role="treeitem">
<li class="tree-item hidden" data-template="treeitem" role="treeitem">
<button class="tree-item-name">
<span class="glyphicon icon-item fueluxicon-bullet"></span>
<span class="tree-label"></span>
Expand Down
4 changes: 2 additions & 2 deletions js/datepicker.js
View file
Expand Up @@ -591,10 +591,10 @@

if (this.sameYearOnly) {
this.$wheelsMonth.addClass('full');
this.$wheelsYear.addClass('hide');
this.$wheelsYear.addClass('hidden');
} else {
this.$wheelsMonth.removeClass('full');
this.$wheelsYear.removeClass('hide');
this.$wheelsYear.removeClass('hide hidden'); // .hide is deprecated
}

$monthUl.find('.selected').removeClass('selected');
Expand Down
2 changes: 1 addition & 1 deletion js/radio.js
View file
Expand Up @@ -159,7 +159,7 @@
$(selector).addClass('hidden');
$(selector).attr('aria-hidden', 'true');
});
this.$toggleContainer.removeClass('hide hidden');
this.$toggleContainer.removeClass('hide hidden'); // hide is deprecated
this.$toggleContainer.attr('aria-hidden', 'false');
} else {
this.$toggleContainer.addClass('hidden');
Expand Down
20 changes: 10 additions & 10 deletions js/scheduler.js
View file
Expand Up @@ -200,17 +200,17 @@
}

// hide all panels
this.$endAfter.parent().addClass('hide');
this.$endAfter.parent().addClass('hidden');
this.$endAfter.parent().attr('aria-hidden', 'true');

this.$endDate.parent().addClass('hide');
this.$endDate.parent().addClass('hidden');
this.$endDate.parent().attr('aria-hidden', 'true');

if (val === 'after') {
this.$endAfter.parent().removeClass('hide');
this.$endAfter.parent().removeClass('hide hidden'); // hide is deprecated
this.$endAfter.parent().attr('aria-hidden', 'false');
} else if (val === 'date') {
this.$endDate.parent().removeClass('hide');
this.$endDate.parent().removeClass('hide hidden'); // hide is deprecated
this.$endDate.parent().attr('aria-hidden', 'false');
}
},
Expand Down Expand Up @@ -382,30 +382,30 @@
case 'daily':
case 'weekly':
case 'monthly':
this.$repeatIntervalPanel.removeClass('hide');
this.$repeatIntervalPanel.removeClass('hide hidden'); // hide is deprecated
this.$repeatIntervalPanel.attr('aria-hidden', 'false');
break;
default:
this.$repeatIntervalPanel.addClass('hide');
this.$repeatIntervalPanel.addClass('hidden'); // hide is deprecated
this.$repeatIntervalPanel.attr('aria-hidden', 'true');
break;
}

// hide all panels
this.$recurrencePanels.addClass('hide');
this.$recurrencePanels.addClass('hidden');
this.$recurrencePanels.attr('aria-hidden', 'true');

// show panel for current selection
this.$element.find('.repeat-' + val).removeClass('hide');
this.$element.find('.repeat-' + val).removeClass('hide hidden'); // hide is deprecated
this.$element.find('.repeat-' + val).attr('aria-hidden', 'false');

// the end selection should only be shown when
// the repeat interval is not "None (run once)"
if (val === 'none') {
this.$end.addClass('hide');
this.$end.addClass('hidden');
this.$end.attr('aria-hidden', 'true');
} else {
this.$end.removeClass('hide');
this.$end.removeClass('hide hidden'); // hide is deprecated
this.$end.attr('aria-hidden', 'false');
}
},
Expand Down
24 changes: 13 additions & 11 deletions js/tree.js
View file
Expand Up @@ -78,19 +78,19 @@
var loader = $parent.find('.tree-loader:eq(0)');
var treeData = $parent.data();

loader.removeClass('hide');
loader.removeClass('hide hidden'); // hide is deprecated
this.options.dataSource(treeData ? treeData : {}, function (items) {
loader.addClass('hide');
loader.addClass('hidden');

$.each(items.data, function (index, value) {
var $entity;

if (value.type === 'folder') {
$entity = self.$element.find('[data-template=treebranch]:eq(0)').clone().removeClass('hide').removeData('template');
$entity = self.$element.find('[data-template=treebranch]:eq(0)').clone().removeClass('hide hidden').removeData('template'); // hide is deprecated
$entity.data(value);
$entity.find('.tree-branch-name > .tree-label').html(value.text || value.name);
} else if (value.type === 'item') {
$entity = self.$element.find('[data-template=treeitem]:eq(0)').clone().removeClass('hide').removeData('template');
$entity = self.$element.find('[data-template=treeitem]:eq(0)').clone().removeClass('hide hidden').removeData('template'); // hide is deprecated
$entity.find('.tree-item-name > .tree-label').html(value.text || value.name);
$entity.data(value);
}
Expand Down Expand Up @@ -228,7 +228,7 @@
//take care of the styles
$branch.addClass('tree-open');
$branch.attr('aria-expanded', 'true');
$treeFolderContentFirstChild.removeClass('hide');
$treeFolderContentFirstChild.removeClass('hide hidden'); // hide is deprecated
$branch.find('> .tree-branch-header .icon-folder').eq(0)
.removeClass('glyphicon-folder-close')
.addClass('glyphicon-folder-open');
Expand All @@ -250,7 +250,7 @@
//take care of the styles
$branch.removeClass('tree-open');
$branch.attr('aria-expanded', 'false');
$treeFolderContentFirstChild.addClass('hide');
$treeFolderContentFirstChild.addClass('hidden');
$branch.find('> .tree-branch-header .icon-folder').eq(0)
.removeClass('glyphicon-folder-open')
.addClass('glyphicon-folder-close');
Expand Down Expand Up @@ -339,7 +339,8 @@
var closedReported = function closedReported(event, closed) {
reportedClosed.push(closed);

if (self.$element.find(".tree-branch.tree-open:not('.hide')").length === 0) {
// hide is deprecated
if (self.$element.find(".tree-branch.tree-open:not('.hidden, .hide')").length === 0) {
self.$element.trigger('closedAll.fu.tree', {
tree: self.$element,
reportedClosed: reportedClosed
Expand All @@ -351,15 +352,16 @@
//trigger callback when all folders have reported closed
self.$element.on('closed.fu.tree', closedReported);

self.$element.find(".tree-branch.tree-open:not('.hide')").each(function () {
self.$element.find(".tree-branch.tree-open:not('.hidden, .hide')").each(function () {
self.closeFolder(this);
});
},

//disclose visible will only disclose visible tree folders
discloseVisible: function discloseVisible() {
var self = this;
var $openableFolders = self.$element.find(".tree-branch:not('.tree-open, .hide')");

var $openableFolders = self.$element.find(".tree-branch:not('.tree-open, .hidden, .hide')");
var reportedOpened = [];

var openReported = function openReported(event, opened) {
Expand All @@ -382,7 +384,7 @@
self.$element.on('loaded.fu.tree', openReported);

// open all visible folders
self.$element.find(".tree-branch:not('.tree-open, .hide')").each(function triggerOpen() {
self.$element.find(".tree-branch:not('.tree-open, .hidden, .hide')").each(function triggerOpen() {
self.openFolder($(this).find('.tree-branch-header'), true);
});
},
Expand All @@ -401,7 +403,7 @@
}

var isExceededLimit = (self.options.disclosuresUpperLimit >= 1 && self.$element.data('disclosures') >= self.options.disclosuresUpperLimit);
var isAllDisclosed = self.$element.find(".tree-branch:not('.tree-open, .hide')").length === 0;
var isAllDisclosed = self.$element.find(".tree-branch:not('.tree-open, .hidden, .hide')").length === 0;


if (!isAllDisclosed) {
Expand Down
14 changes: 7 additions & 7 deletions markup/scheduler.html
View file
Expand Up @@ -280,7 +280,7 @@ <h2 class="header">Year</h2>
<input type="text" aria-hidden="true" readonly="readonly" name="intervalSelectlist" class="hidden hidden-field">
</div>

<div class="repeat-panel repeat-every-panel repeat-hourly repeat-daily repeat-weekly hide" aria-hidden="true">
<div class="repeat-panel repeat-every-panel repeat-hourly repeat-daily repeat-weekly hidden" aria-hidden="true">
<label id="MySchedulerEveryLabel" class="inline-form-text repeat-every-pretext">every</label>

<div class="spinbox digits-3 repeat-every">
Expand All @@ -299,7 +299,7 @@ <h2 class="header">Year</h2>
</div>
</div>

<div class="form-group repeat-panel repeat-weekly repeat-days-of-the-week hide" aria-hidden="true">
<div class="form-group repeat-panel repeat-weekly repeat-days-of-the-week hidden" aria-hidden="true">
<fieldset class="btn-group" data-toggle="buttons">
<label class="btn btn-default">
<input type="checkbox" data-value="SU">Sun
Expand All @@ -326,7 +326,7 @@ <h2 class="header">Year</h2>
</div>


<div class="repeat-panel repeat-monthly hide" aria-hidden="true">
<div class="repeat-panel repeat-monthly hidden" aria-hidden="true">
<div class="form-group repeat-monthly-date">
<div class="radio pull-left">
<label class="radio-custom">
Expand Down Expand Up @@ -423,7 +423,7 @@ <h2 class="header">Year</h2>
</div>
</div>

<div class="repeat-panel repeat-yearly hide" aria-hidden="true">
<div class="repeat-panel repeat-yearly hidden" aria-hidden="true">

<div class="form-group repeat-yearly-date">

Expand Down Expand Up @@ -568,7 +568,7 @@ <h2 class="header">Year</h2>
</div>
</div>

<div class="form-group repeat-end hide" aria-hidden="true">
<div class="form-group repeat-end hidden" aria-hidden="true">
<label class="col-sm-2 control-label scheduler-label">End</label>
<div class="col-sm-10 row">
<div class="col-sm-3 form-group">
Expand All @@ -587,7 +587,7 @@ <h2 class="header">Year</h2>
</div>
</div>

<div class="col-sm-6 form-group end-option-panel end-after-panel pull-left hide" aria-hidden="true">
<div class="col-sm-6 form-group end-option-panel end-after-panel pull-left hidden" aria-hidden="true">
<div class="spinbox digits-3 end-after">
<label id="MyEndAfter" class="sr-only">End After</label>
<input type="text" class="form-control input-mini spinbox-input" aria-labelledby="MyEndAfter">
Expand All @@ -603,7 +603,7 @@ <h2 class="header">Year</h2>
<div class="inline-form-text end-after-text">occurrence(s)</div>
</div>

<div class="col-sm-8 form-group end-option-panel end-on-date-panel pull-left hide" aria-hidden="true">
<div class="col-sm-8 form-group end-option-panel end-on-date-panel pull-left hidden" aria-hidden="true">
<div class="datepicker input-group end-on-date">
<div class="input-group">
<input class="form-control" type="text"/>
Expand Down
4 changes: 2 additions & 2 deletions markup/tree-folders-selectable.html
View file
@@ -1,5 +1,5 @@
<ul class="tree tree-folder-select" id="myTree" role="tree">
<li class="tree-branch hide" data-template="treebranch" role="treeitem" aria-expanded="false">
<li class="tree-branch hidden" data-template="treebranch" role="treeitem" aria-expanded="false">
<div class="tree-branch-header">
<button class="glyphicon icon-caret glyphicon-play"><span class="sr-only">Open</span></button>
<button class="tree-branch-name">
Expand All @@ -10,7 +10,7 @@
<ul class="tree-branch-children" role="group"></ul>
<div class="tree-loader" role="alert">Loading...</div>
</li>
<li class="tree-item hide" data-template="treeitem" role="treeitem">
<li class="tree-item hidden" data-template="treeitem" role="treeitem">
<button class="tree-item-name">
<span class="glyphicon icon-item fueluxicon-bullet"></span>
<span class="tree-label"></span>
Expand Down
4 changes: 2 additions & 2 deletions markup/tree.html
View file
@@ -1,5 +1,5 @@
<ul class="tree" id="myTree" role="tree">
<li class="tree-branch hide" data-template="treebranch" role="treeitem" aria-expanded="false">
<li class="tree-branch hidden" data-template="treebranch" role="treeitem" aria-expanded="false">
<div class="tree-branch-header">
<button class="tree-branch-name">
<span class="glyphicon icon-caret glyphicon-play"></span>
Expand All @@ -10,7 +10,7 @@
<ul class="tree-branch-children" role="group"></ul>
<div class="tree-loader" role="alert">Loading...</div>
</li>
<li class="tree-item hide" data-template="treeitem" role="treeitem">
<li class="tree-item hidden" data-template="treeitem" role="treeitem">
<button class="tree-item-name">
<span class="glyphicon icon-item fueluxicon-bullet"></span>
<span class="tree-label"></span>
Expand Down
2 changes: 1 addition & 1 deletion test/datepicker-moment-test.js
View file
Expand Up @@ -172,7 +172,7 @@ define(function(require){
equal($titleYear.text(), '1987', 'user can\'t prev click outside current year');

$titleButton.trigger('click');
equal($datepicker.find('.datepicker-wheels-year').hasClass('hide'), true, 'years wheel hidden');
equal($datepicker.find('.datepicker-wheels-year').hasClass('hidden'), true, 'years wheel hidden');

$datepickerInput.val('03/31/1988');
$datepickerInput.trigger('blur');
Expand Down

0 comments on commit f9e5c9b

Please sign in to comment.