Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Allow repeater to initialize without a dataSource and no options #1182

Merged
merged 4 commits into from Mar 24, 2015
Merged

Allow repeater to initialize without a dataSource and no options #1182

merged 4 commits into from Mar 24, 2015

Conversation

kevinparkerson
Copy link
Contributor

Fixes #1167 by allowing repeater to load if no dataSource has been provided. Also attempts to address issue #1166 by making the repeater still function if bad data or no data is passed back in the dataSource, and provides better defaults for itemization and pagination in the event of poor data scenarios.

Also fixes a random bug I noticed with the deselected event in repeater-list

…st where event was not properly triggered and caused an error
… dataSource. also provides better defaults when poor data (or no data) is returned from the dataSource
@mbeard
Copy link
Contributor

mbeard commented Mar 23, 2015

@kevinparkerson - does this allow for rendering of the column headers prior to data being loaded?

@kevinparkerson
Copy link
Contributor Author

@mbeard not in this PR, but that is something we could do for a new issue / PR. I think it would be the addition of a "renderColumnHeaders" function to repeater-list

@interactivellama
Copy link
Contributor

This is working great with repeater-list. When I use repeater thumbnail view as default, I do not get no items found on the repo's index.html page, even though it's specified in the initiation options.

screen shot 2015-03-23 at 4 50 37 pm

…ainer rendering and sets default noItemsHTML for both repeater-list and repeater-thumbnail
@kevinparkerson
Copy link
Contributor Author

There was some bad logic from the plugin API translation in the repeater-thumbnail before function that would not render the thumbnail container in certain circumstances, so the noItemsHTML never appeared. Good catch!

@interactivellama
Copy link
Contributor

Font size needs to be over written if empty. It's currently .1px, so "no items found" is present, but not readable.

screen shot 2015-03-24 at 9 17 11 am

interactivellama added a commit that referenced this pull request Mar 24, 2015
@interactivellama interactivellama merged commit 7c299f6 into ExactTarget:master Mar 24, 2015
@interactivellama interactivellama changed the title Repeater better defaults Allow no dataSource and additional default options Apr 7, 2015
@interactivellama interactivellama changed the title Allow no dataSource and additional default options Allow repeater to initialize without a dataSource and no options Apr 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants