bgm123 - update with several improvements #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the extra menu script, it's all rolled back into the gui_ function for now. Added a mapped_volume switch to use a different fade-in/out profile.
Added "enabled" status to user config. Fixes "not enabled after uninstall/reinstall." Expanded comments.
I guess this separation of declaration and assignment is probably not necessary, after all.
SIGKILL should patch this for now but it's a dirty fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimented with a stand-alone menu script, but went back to just using the gui_ function.
Added a config file to allow for user-controlled settings.
For now only have "mapped_volume" option to use a different fade profile.
You can manually edit "music_dir" in config file to use a different location but no GUI for this (yet).
"mixer_channel" and "music_player" options don't do anything (yet). Don't edit them.
Broke all player controls into external scripts to manage them easier.
One issue: if you PAUSE then DISABLE then ENABLE then PLAY, it doesn't start. Selecting PLAY a second time usually works.
Disabling without pausing first doesn't seem to cause any issues. Disabling while paused, the process does not
pkillproperly and remains open in a "stopped" state.Quitting while paused may have the same issues, as it calls the same kill function to stop the music as disabling does, and repeated testing of this may be the reason my audio got corrupted last night (rebooting fixed it, though) as I suspect I ended up with multiple overlapping processes competing for the audio channel.
I am still investigating the solution to this problem.