Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

growntilebox #142

Merged

Conversation

michaeljbrazell
Copy link
Contributor

  • changed the compute_* functions to use tilebox and not a grown one
  • this requires a fillpatch afterwards.
  • Added a two level static refinment ABL regression test
  • upgraded strain rate unit test to quadratic polynomials
  • removed random variable from analytical function and loosened scalar laplacian tolerance
  • tilebox/fillpatch approach gives a different solution than using grown tile box when number of levels > 0

…his requires a fillpatch afterwards. Added a two level static refinment ABL regression test
src/turbulence/LES/Smagorinsky.H Outdated Show resolved Hide resolved
@gdeskos
Copy link
Contributor

gdeskos commented May 29, 2020

So do we still have to lower the tolerance for the laplacian to pass after you removed the random number factor from the grid spacing ? Also while there, can you apply the attached patch ? This is to fix a bug in field_algebra.cpp

diff --git a/src/derive/field_algebra.cpp b/src/derive/field_algebra.cpp
index 3982c28..0b50a78 100644
--- a/src/derive/field_algebra.cpp
+++ b/src/derive/field_algebra.cpp
@@ -23,7 +23,7 @@ void normalize_field(FType& Field)
                 }
                 //Normalize field
                 for (int icomp=0;icomp<ncomp;++icomp){
-                    field_arr(i,j,k)=field_arr(i,j,k,icomp)/std::sqrt(mag);
+                    field_arr(i,j,k,icomp)=field_arr(i,j,k,icomp)/std::sqrt(mag);
                 }
 
                 });

@michaeljbrazell
Copy link
Contributor Author

@gdeskos yes I needed to remove random and adjust tolerance. fixed the icomp bug, thanks!

@michaeljbrazell michaeljbrazell merged commit 80d41a3 into Exawind:development May 29, 2020
@michaeljbrazell michaeljbrazell deleted the mjb/derive_growntilebox branch October 16, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants