Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing a wall modeled LES channel flow #836

Merged
merged 18 commits into from
May 4, 2023

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Apr 27, 2023

This PR adds:

  • an analytical Smagorinsky channel test
  • a constant shear stress wall model boundary condition

TODO:

  • lift restrictions of wall normal direction, or at least guard against it
  • add regtest
  • document convergence run

FYI: @asalmgren @mbkuhn @moprak-nrel @AMLattanzi

Co-authored-by: moprak-nrel 120606615+moprak-nrel@users.noreply.github.com

@marchdf
Copy link
Contributor Author

marchdf commented May 1, 2023

I hate to ask but... are you going to do this for vorticity, laplacian, q-critierion, and gradient as well?

@mbkuhn
Copy link
Contributor

mbkuhn commented May 1, 2023

I hate to ask but... are you going to do this for vorticity, laplacian, q-critierion, and gradient as well?

This PR will only address the operators in ABLStats and turbulence modeling. Which means only gradient and strainrate. But the others can be addressed in a future PR.

@marchdf marchdf marked this pull request as ready for review May 4, 2023 13:27
@marchdf marchdf enabled auto-merge (squash) May 4, 2023 19:26
@marchdf marchdf merged commit bbe0fdd into Exawind:main May 4, 2023
13 checks passed
@marchdf marchdf deleted the channel-modifs branch May 4, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants