Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove meshes not used in regression tests #11

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

psakievich
Copy link
Contributor

@psakievich psakievich commented Oct 7, 2022

I did a scan of the meshes we are not using for regression tests in the exawind-driver or nalu-wind. It is the majority of the repo. I'd like to give people a few days to comment and weigh in on if we should be keeping any of these, or if we should have tests using these meshes that are not there.

Our mesh repo is really a bottle neck for cloning and other issues though because it is so big. I would suggest that if we want a repo of meshes for historical purposes or verification tests we fork this one prior to this commit and don't submodule it in our codes. I'd like to keep the one paired to the actual codes as slim as possible.

Using du -shc this PR alone drops the mesh repo size from 1GB to 519MB

@ashesh2512
Copy link
Contributor

If they aren’t used, I don’t see a reason to carry them around.

@marchdf
Copy link
Contributor

marchdf commented Oct 7, 2022

Same. Great idea.

Copy link
Contributor

@jrood-nrel jrood-nrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. To actually shrink the repo we will have to purge the history. It will screw up the submodule in Nalu-Wind and Exawind, but hopefully the fix is to just update the submodule to the single commit in this repo.

@psakievich psakievich marked this pull request as ready for review October 7, 2022 16:25
@psakievich
Copy link
Contributor Author

Going to merge now, but we will wait until next week to purge the git history.

@psakievich psakievich merged commit 5c0fd2f into master Oct 7, 2022
@psakievich psakievich deleted the rm-unused branch October 7, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants