Support cached formula string values #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify ExcelOpenXmlReader to treat "str" cell type the same as "inlineString". Modify ExcelOpenXmlReader to use the original cell value converted to a string rather than the value parsed as a double. Add unit test. Modify the "Issue_11573_BlankValues" test to check for a string instead of a number since string formula values are no longer parsed as numbers.
|
Do you have any time frame on merging this PR and making a release? Or is there something I need to fix? |
|
I haven't had any time to look into this yet as my paid project work is too On Mon, Mar 23, 2015 at 4:20 PM, Jason Addington notifications@github.com
Ian Cox System Sync Registered in England as systemsync solutions ltd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for cached formula string values by handling them like inline strings. Additionally, I've modified inline string/cache formula string handling to not use the parsed double value, but instead take the cell value as a string.
I've added the
Issue_53_Cached_Formula_String_Typeunit test for this issue.Note that this PR changed the behavior of one of the unit tests.
Issue_11573_BlankValuesread a value with a leading zero, then asserted it was a double. Since this was a formula cell that did a lookup on a text cell, Excel set the cell type a cached formula string value. The new behavior is that this should be read as a string. I modified the test to match the new behavior.Fixes #53
Potentially addresses #47 and #31