-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(arby): upgrade mainnet to v1.1.8 #687
Conversation
Solutions:
Screenshot from 2020-08-26 12-56-02
Result: price throttling works well, but first two bugs should be fixed before merging to master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
above
I believe #1 is the correct thing to do. There is no need for the orderbook to "look active" as in "constantly changing prices". The liquidity just needs to be there and more importantly swaps need to work reliably. |
What's your take? @erkarl |
not sure but with several orders in row it may lead to several noOrderErr's. |
3d5c185
to
7dc877d
Compare
@raladev ready for testing again. |
Screenshot from 2020-08-27 21-16-09
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above
7dc877d
to
d4dbe7b
Compare
The first 2 issues should now be addressed. Created a follow-up issue for the 3rd one: ExchangeUnion/market-maker-bot#84 Doesn't matter. It happens in parallel. |
This PR upgrades arby to v1.1.6 which should mitigate the issue with orders updating too quickly for the decentralized orderbook. Orders are now updated only if a greater than 0.1% price movement happens.
Please test
arby:latest
on simnet/testnet before merging this.