Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove part of an order #714

Closed
sangaman opened this issue Nov 30, 2018 · 1 comment
Closed

Remove part of an order #714

sangaman opened this issue Nov 30, 2018 · 1 comment
Assignees
@sangaman @rsercano
Labels
grpc gRPC API has PR issues with an open PR order book P1 top priority
Milestone
1.0.0-alpha.8

Comments

@sangaman
Copy link
Collaborator

Currently we can only remove an entire order via the rpc layer. I think it would probably be useful to be able to remove only part of an order by specifying a quantity on the RemoveOrderRequest.
@sangaman sangaman added good first issue Good for newcomers grpc gRPC API order book labels Nov 30, 2018
@kilrau kilrau added this to the 1.0.0-alpha.7 milestone Nov 30, 2018
@kilrau kilrau modified the milestones: 1.0.0-alpha.7, 1.0.0-alpha.8 Jan 2, 2019
@kilrau kilrau modified the milestones: 1.0.0-alpha.7, 1.0.0-alpha.8 Jan 23, 2019
@kilrau
Copy link
Contributor

kilrau commented Jan 23, 2019

This would be quite nice to get in soon - do you think you'll have the bandwidth to work on it til January 31st? @rsercano

@kilrau kilrau added P1 top priority and removed good first issue Good for newcomers labels Jan 23, 2019
rsercano pushed a commit to rsercano/xud that referenced this issue Jan 24, 2019
initial implementation ExchangeUnion#714
be6ebd1
@rsercano rsercano mentioned this issue Jan 24, 2019
Closed
@ghost ghost added the in progress label Jan 24, 2019
@rsercano rsercano added the has PR issues with an open PR label Jan 24, 2019
rsercano added a commit to rsercano/xud that referenced this issue Feb 5, 2019
@rsercano
Merge branch 'master' into ExchangeUnion#714
300fc39
sangaman pushed a commit that referenced this issue Feb 5, 2019
@sangaman
feat(orderbook): partial order removal
bc3913b 
This allows for only part of any order to be removed via the rpc layer.
Previously it was only possible to remove entire orders.

Closes #714.
@sangaman sangaman mentioned this issue Feb 5, 2019
Merged
@ghost ghost assigned sangaman Feb 5, 2019
@ghost ghost removed the in progress label Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

@rsercano rsercano

Labels
grpc gRPC API has PR issues with an open PR order book P1 top priority
Projects
None yet
Milestone
1.0.0-alpha.8
Development

Successfully merging a pull request may close this issue.

Partial order removal #714 rsercano/xud
3 participants
@sangaman @rsercano @kilrau