refactor(orderbook): throw error on non-swap fail #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tweaks the logic around handling exceptions that arise from swap execution to ensure that the exception is a valid `SwapFailureReason` and to clarify the log messages and intent of the code. If the exception is not a `SwapFailureReason` we abort the matching procedure instead of repeating it for the failed amount.
sangaman
added
error handling
ghost
assigned 
erkarl
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the logic around handling exceptions that arise from swap execution to ensure that the exception is a valid
SwapFailureReasonand to clarify the log messages and intent of the code. If the exception is not aSwapFailureReasonwe abort the matching procedure instead of repeating it for the failed amount.