New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve LSM support autodetection #156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoNardi
force-pushed
the
155-improve-lsm-support-autodetection
branch
from
February 10, 2023 16:06
c626318
to
cef5533
Compare
The new global setting `lsm_support` allows to skip LSM support autodetection. The valid values are 'autodetect', 'true', 'false'. By default we try to autodetect.
MatteoNardi
force-pushed
the
155-improve-lsm-support-autodetection
branch
from
February 17, 2023 09:58
b96280c
to
8f861c6
Compare
I advise to review commit by commit since the first one contains a lot of moved files. A few notes:
|
4 tasks
banditopazzo
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart few minor things looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve LSM autodetection by trying to load an example LSM program.
bpf-builder
to its own crate becausebpf-common
would have needed to depend on itself at build-time.lsm_supported
to BpfContext in order to avoid repeating the time-consuming check.I have
cargo fmt
;cargo clippy
;cargo test
and all tests pass;