Test suite refactor #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoNardi
force-pushed
the
test-suite
branch
2 times, most recently
from
0e01450
to
747cbf8
Compare
|
All the test were ported to the new system. I'll work on documentation and general cleanup, than it will be ready for review. |
|
This PR is now ready for review.
Some notes:
|
banditopazzo
requested changes
Aug 22, 2022
I noticed trace pipe logging stopped working and I tracked down the issue to the original file descriptor being closed too soon (when returning from open_trace_pipe). Turns out AsyncFd is not taking ownership the the original file and we must keep it around until we're done reading)
Previously we decided to make `probe` an example because we had only another binary (`pulsar-exec`) and it made sense to have it as the default target. Now we've added move binaries (`xtask`, `test-suite`) and we don't run binaries directly with `cargo run` because it lacks root privileges.
This reverts commit 9d8be0e.
MatteoNardi
force-pushed
the
test-suite
branch
from
0da0532
to
2b3e584
Compare
|
I've rebased to main and added 2b3e584 |
Before this change, the panic message was displayed in the middle of the test lines. libtest-mimic didn't write `FAILURE` because the test stopped. After this change, the test completes with a FAILURE line and the panic message is displayed at the bottom of the screen.
banditopazzo
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a tentative refactor of the test suite.
Tests are split in a different binary, which can be invoked with sudo by using a xtask.
Fixes #3