Emit cgroup events from process-monitor #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match the size/alignment of Rust `repr(C)` enums, we replaced:
```
u64 timestamp;
u32 pid;
u32 event_type;
union {...};
```
With:
```
u64 timestamp;
u32 pid;
struct {
u32 event_type;
union {...};
};
```
The old code caused problems when the union contained a u64.
This is the layout of the two snippets:
```
Snippet 1, no wrapping struct:
________ ____ ____ ________
^timestamp ^event_type
^pid ^union
Snippet 2, wrapping struct (. are padding bytes):
________ ____ .... ____ .... ________
^timestamp ^event_type
^pid ^union
```
MatteoNardi
changed the title
MatteoNardi
force-pushed
the
cgroup_events
branch
from
a1a4e6b
to
4aaf87c
Compare
banditopazzo
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cgroup integration inside process-monitor.
I've decided to split work on #13 in two PRs, this is the simplest one, while in the next one I'll work on filtering.
cgroup_mkdirPayload::CgroupCreatedcgroup_rmdirPayload::CgroupDeletedcgroup_attach_taskPayload::CgroupAttachI've successfully tested it on x86_64 (5.5 and 5.19) and aarch64 (6.0)
I have
cargo fmt;cargo clippy;cargo testand all tests pass;