Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed docker-compose up adding start_server.py #120

Merged
merged 1 commit into from
May 8, 2023

Conversation

gdjohn4s
Copy link
Member

@gdjohn4s gdjohn4s commented May 7, 2023

Description

This PR contains the fix for docker-compose on Windows environments.

Screenshots

image

Technical Details

The created script is start_server.py which runs the server start command python start.py. If it doesn't work, it launches the command python**3** start.py (this is because the Python interpreter might be called in either way).

Related Issues

This PR is related to the issue #119.

Pull Request Checklist

  • Code follows the established CODE_OF_CONDUCT guidelines.
  • Code has been tested thoroughly and passes all tests.
  • All commit messages are descriptive and follow the established commit message format.
  • Pull request title follows the established pull request title format.
  • Pull request description clearly describes the changes included in the pull request.

@gdjohn4s gdjohn4s requested a review from FlavioAdamo May 8, 2023 08:42
@FlavioAdamo FlavioAdamo merged commit 07cb67b into main May 8, 2023
1 check passed
@gdjohn4s gdjohn4s deleted the issue_119_docker_fix branch May 8, 2023 12:05
@gdjohn4s gdjohn4s mentioned this pull request May 8, 2023
@gdjohn4s gdjohn4s mentioned this pull request May 23, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants