Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/be fe sync and code refactoring #214

Merged
merged 15 commits into from
Jun 24, 2023
Merged

Fix/be fe sync and code refactoring #214

merged 15 commits into from
Jun 24, 2023

Conversation

gdjohn4s
Copy link
Member

@gdjohn4s gdjohn4s commented Jun 20, 2023 •
edited

Description

Refactored all components to get better performance and readability.
Aligned new backend authorized apis with frontend services.

Checklist

  • My submission is formatted according to the guidelines in the contributing guide
  • My addition is ordered alphabetically
  • My submission has a useful description
  • Code follows the established CODE_OF_CONDUCT guidelines.
  • Code has been tested thoroughly and passes all tests.
  • All commit messages are descriptive and follow the established commit message format.
  • Pull request title follows the established pull request title format.
  • Pull request description clearly describes the changes included in the pull request.
  • The description does not have more than 100 characters
  • Each table column is padded with one space on either side
  • I have searched the repository for any relevant issues or pull requests
  • Any category I am creating has the minimum requirement of 3 items

@gdjohn4s gdjohn4s added enhancement New feature or request frontend labels Jun 20, 2023
@gdjohn4s
Update settings.py
f475f12
@gdjohn4s
fix/code cleaned and optimised
5f4a695 
removed:
- unusued imports
- unusued variables

added:
- `ref<boolean>` for isLikedByUser
@gdjohn4s
feat/added scale animation for buttons hover
6975a00
@gdjohn4s
Merge pull request #215 from Exifly/fix/like_btn_when_not_auth
b0f1ab1 
Fix/interaction hover effect and optimised
@gdjohn4s gdjohn4s merged commit cb60e86 into main Jun 24, 2023
1 check passed
@gdjohn4s gdjohn4s deleted the fix/be_fe_sync branch June 24, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlavioAdamo FlavioAdamo FlavioAdamo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gdjohn4s @FlavioAdamo