Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/added a dropdown Menu when user is logged to choose what to do. #218

Merged
merged 2 commits into from
Jun 24, 2023
Merged

feat/added a dropdown Menu when user is logged to choose what to do. #218

merged 2 commits into from
Jun 24, 2023

Conversation

gdjohn4s
Copy link
Member

Description

Changed the user info menu to a Dropdown menu in the navbar.

Proposed Changes

Screenshot 2023-06-21 at 17 42 05

Checklist

  • My submission is formatted according to the guidelines in the contributing guide
  • My addition is ordered alphabetically
  • My submission has a useful description
  • Code follows the established CODE_OF_CONDUCT guidelines.
  • Code has been tested thoroughly and passes all tests.
  • All commit messages are descriptive and follow the established commit message format.
  • Pull request title follows the established pull request title format.
  • Pull request description clearly describes the changes included in the pull request.
  • The description does not have more than 100 characters
  • Each table column is padded with one space on either side
  • I have searched the repository for any relevant issues or pull requests
  • Any category I am creating has the minimum requirement of 3 items

@gdjohn4s gdjohn4s added enhancement New feature or request frontend labels Jun 21, 2023
gdjohn4s
gdjohn4s commented Jun 21, 2023
View reviewed changes
frontend/components/Navbar.vue Outdated
<!-- v-if="isLogged" -->
<!-- @click="() => logout()" -->
<!-- :username="user" -->
<!-- /> -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is just a reminder to @click="() => logout()"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT:
this comment has been removed in the new commits!

@gdjohn4s
feat/added rounded img as user profile picture
3f7497f 
fix/handled logout event in dropdown menu
fix/handled mobile screen classes for login button and nav elements
fix/removed bg hover effect in dropdown items
@FlavioAdamo FlavioAdamo merged commit ab476e4 into main Jun 24, 2023
1 check passed
@FlavioAdamo FlavioAdamo deleted the feat/user_dropdown_navbar branch June 24, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlavioAdamo FlavioAdamo FlavioAdamo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gdjohn4s @FlavioAdamo