Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributors link added to Footer #98

Merged
merged 2 commits into from
May 4, 2023
Merged

Contributors link added to Footer #98

merged 2 commits into from
May 4, 2023

Conversation

kotkaravishkar
Copy link
Contributor

Fixed #94

Changes-

  • Removed "Coded by gdjohn4s & flavioad " In the footer.

  • The new text will be "Coded by those wonderful people

screenshot-

contributors-footer png

gdjohn4s
gdjohn4s requested changes May 4, 2023
View reviewed changes
Copy link
Member

@gdjohn4s gdjohn4s left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
Can you please use the<router-link> component instead <a> tag?

That's because the intern routes are managed by vue-router and not by html itself 😄
Thanks

@gdjohn4s gdjohn4s added enhancement New feature or request frontend labels May 4, 2023
gdjohn4s
gdjohn4s approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@gdjohn4s gdjohn4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, approved ✅

@gdjohn4s gdjohn4s merged commit 1fe4e3e into Exifly:main May 4, 2023
1 check passed
@kotkaravishkar
Copy link
Contributor Author

@gdjohn4s thank you

@gdjohn4s gdjohn4s mentioned this pull request May 23, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdjohn4s gdjohn4s gdjohn4s approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add contributors link in the footer
2 participants
@kotkaravishkar @gdjohn4s