Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InspectingWeaponEvent #2063

Closed
wants to merge 17 commits into from
Closed

Add InspectingWeaponEvent #2063

wants to merge 17 commits into from

Conversation

Ruemena
Copy link
Contributor

@Ruemena Ruemena commented Sep 3, 2023

tested and works fine + builds pass

@NaoUnderscore NaoUnderscore added enhancement New feature or request regarding-events tested This PR has been built and tested and does not cause any obvious errors. P3 Low Priority and removed regarding-api labels Sep 4, 2023
@louis1706 louis1706 added this to In progress in EXILED Workflow via automation Sep 4, 2023
EXILED Workflow automation moved this from In progress to Review in progress Sep 4, 2023
@Ruemena Ruemena requested a review from IRacle1 September 4, 2023 18:17
Thundermaker300
Thundermaker300 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@Thundermaker300 Thundermaker300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs IL Review

louis1706
louis1706 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@louis1706 louis1706 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IL code seems fine

i would just like he verify what happen when IsAllowed = false because of where the event is place

@louis1706 louis1706 added requires-testing Things need to be verified by an Exiled Developer/Contributor and removed tested This PR has been built and tested and does not cause any obvious errors. labels Sep 5, 2023
@Ruemena
Copy link
Contributor Author

Ruemena commented Sep 8, 2023

randomly stopped working ummm

@louis1706 louis1706 moved this from Review in progress to Requires Testing in EXILED Workflow Oct 10, 2023
@louis1706 louis1706 marked this pull request as draft October 25, 2023 15:48
@louis1706
Copy link
Member

i put this as Draft since you said it's wasn't working anymore

louis1706
louis1706 requested changes Oct 28, 2023
View reviewed changes
Exiled.Events/Patches/Events/Player/FirearmRequestReceived.cs
Comment on lines +268 to +269
offset = -3;
index = newInstructions.FindLastIndex(instruction => instruction.opcode == OpCodes.Ldftn) + offset;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need verification with new update

EXILED Workflow automation moved this from Requires Testing to Review in progress Oct 28, 2023
@louis1706 louis1706 moved this from Review in progress to Requires Testing in EXILED Workflow Dec 2, 2023
@NaoUnderscore NaoUnderscore changed the base branch from dev to apis-rework January 14, 2024 04:42
@NaoUnderscore NaoUnderscore added this to the Exiled 9 milestone Jan 14, 2024
@NaoUnderscore NaoUnderscore added P2 Medium priority and removed P3 Low Priority labels Jan 14, 2024
@Misfiy
Copy link
Member

Misfiy commented May 29, 2024

Closing since Rue has left Exiled and does not seem to be returning. This also has not been fixed for months

@Misfiy Misfiy closed this May 29, 2024
EXILED Workflow automation moved this from Requires Testing to Done May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis1706 louis1706 louis1706 requested changes

@Thundermaker300 Thundermaker300 Thundermaker300 approved these changes

@NaoUnderscore NaoUnderscore Awaiting requested review from NaoUnderscore

@IRacle1 IRacle1 Awaiting requested review from IRacle1

Assignees

@Ruemena Ruemena

Labels
enhancement New feature or request P2 Medium priority regarding-events regarding-transpiler requires-testing Things need to be verified by an Exiled Developer/Contributor
Projects
EXILED Workflow
Done
Milestone
Exiled 9
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ruemena @louis1706 @Misfiy @Thundermaker300 @NaoUnderscore @IRacle1