-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Assets & Singleton #2650
Merged
Merged
Fix Assets & Singleton #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VALERA771
added
bug
Something isn't working
tested
This PR has been built and tested and does not cause any obvious errors.
regarding-api
labels
Jun 29, 2024
VALERA771
approved these changes
Jun 29, 2024
NaoUnderscore
added a commit
that referenced
this pull request
Jul 1, 2024
* Core's assets have been implemented: - Added new classes and attributes for improved entity management. - Added AssetFragment, EClass, EntityAsset, and related attributes. - Any types implementing IAssetFragment can be used to generate a fragment or an EntityAsset. - Began adding EProperty attributes to classes which are supposed to be used to generate fragments and assets. * Implemented `EProperty` for Items * ?. * Minor changes to `EConfig`. Added an `EClass`. Converted `Effect` class to struct. * Added `Generator` `EClass` * Fix hint's `EClass` * Added more `EClass`'es * Fixed `AssetFragment::GenerateAsset` generating assets from types which are not marked as `EClass`. * Fixed `State` compare by ref instead of value * Minor fixes * All `EClass`'es * Fix warnings * Fix docs * Revert CustomHealthStat.cs * Fix build error * fix conflict? * fix typo * fix removals * fix lag & log spam * Changes & null fix * [Core API] Fix null & invalid cast (#2650) --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com>
This was referenced Jul 1, 2024
NaoUnderscore
added a commit
that referenced
this pull request
Jul 1, 2024
* `[Exiled::Core]` `Assets` and `Fragments` (#2568) * Core's assets have been implemented: - Added new classes and attributes for improved entity management. - Added AssetFragment, EClass, EntityAsset, and related attributes. - Any types implementing IAssetFragment can be used to generate a fragment or an EntityAsset. - Began adding EProperty attributes to classes which are supposed to be used to generate fragments and assets. * Implemented `EProperty` for Items * ?. * Minor changes to `EConfig`. Added an `EClass`. Converted `Effect` class to struct. * Added `Generator` `EClass` * Fix hint's `EClass` * Added more `EClass`'es * Fixed `AssetFragment::GenerateAsset` generating assets from types which are not marked as `EClass`. * Fixed `State` compare by ref instead of value * Minor fixes * All `EClass`'es * Fix warnings * Fix docs * Revert CustomHealthStat.cs * Fix build error * fix conflict? * fix typo * fix removals * fix lag & log spam * Changes & null fix * [Core API] Fix null & invalid cast (#2650) --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com> * Revert "Merge remote-tracking branch 'origin/dev' into apis-rework" This reverts commit 08e279f, reversing changes made to 1b8d3a5. --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com>
NaoUnderscore
added a commit
that referenced
this pull request
Jul 1, 2024
* `[Exiled::Core]` `Assets` and `Fragments` (#2568) * Core's assets have been implemented: - Added new classes and attributes for improved entity management. - Added AssetFragment, EClass, EntityAsset, and related attributes. - Any types implementing IAssetFragment can be used to generate a fragment or an EntityAsset. - Began adding EProperty attributes to classes which are supposed to be used to generate fragments and assets. * Implemented `EProperty` for Items * ?. * Minor changes to `EConfig`. Added an `EClass`. Converted `Effect` class to struct. * Added `Generator` `EClass` * Fix hint's `EClass` * Added more `EClass`'es * Fixed `AssetFragment::GenerateAsset` generating assets from types which are not marked as `EClass`. * Fixed `State` compare by ref instead of value * Minor fixes * All `EClass`'es * Fix warnings * Fix docs * Revert CustomHealthStat.cs * Fix build error * fix conflict? * fix typo * fix removals * fix lag & log spam * Changes & null fix * [Core API] Fix null & invalid cast (#2650) --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com> * Revert "Merge remote-tracking branch 'origin/dev' into apis-rework" This reverts commit 08e279f, reversing changes made to 1b8d3a5. * Exiled9 (#2641) * Changes * that --------- Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com> --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com> Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
NaoUnderscore
added a commit
that referenced
this pull request
Jul 1, 2024
* `[Exiled::Core]` `Assets` and `Fragments` (#2568) * Core's assets have been implemented: - Added new classes and attributes for improved entity management. - Added AssetFragment, EClass, EntityAsset, and related attributes. - Any types implementing IAssetFragment can be used to generate a fragment or an EntityAsset. - Began adding EProperty attributes to classes which are supposed to be used to generate fragments and assets. * Implemented `EProperty` for Items * ?. * Minor changes to `EConfig`. Added an `EClass`. Converted `Effect` class to struct. * Added `Generator` `EClass` * Fix hint's `EClass` * Added more `EClass`'es * Fixed `AssetFragment::GenerateAsset` generating assets from types which are not marked as `EClass`. * Fixed `State` compare by ref instead of value * Minor fixes * All `EClass`'es * Fix warnings * Fix docs * Revert CustomHealthStat.cs * Fix build error * fix conflict? * fix typo * fix removals * fix lag & log spam * Changes & null fix * [Core API] Fix null & invalid cast (#2650) --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com> * Revert "Merge remote-tracking branch 'origin/dev' into apis-rework" This reverts commit 08e279f, reversing changes made to 1b8d3a5. * Exiled9 (#2641) * Changes * that --------- Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com> * Moved modified code. (#2656) --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com> Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com> Co-authored-by: Alex Rouse <123724383+ALEXWARELLC@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
regarding-api
tested
This PR has been built and tested and does not cause any obvious errors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.