Access Violation in value.cpp

[roflcopter4]

Describe the bug

The line 374 in "value.cpp"

      throw Error(ErrorCode::kerInvalidIconvEncoding, encoding, "UTF-8");

can cause an access violation when encoding is NULL. This line of code has been fixed in the nightly and head but the most recent release still contains the old version. encoding ought to be from, as in the current version of the code. Since this breaks the library when used with any bad image file I'd call this bug pretty serious.

To Reproduce

The problem is in program logic and doesn't need to be reproduced. Error passes its argument to a function that turns it into a string via std::ostringstream, which must not be given a NULL const char * pointer.

[neheb]

I assume you're talking about d4f6c9c

[neheb]

#2977 should fix this.

[neheb]

Closing this. Next minor release should fix this.