Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards v3: new stellar data, interpolation, sqrt law, and more. #30

Merged
merged 27 commits into from
Dec 8, 2022

Conversation

DavoGrant
Copy link
Member

Major updates towards the v3 milestone. In this PR we have:

The docs have been updated with the latest info for installation, supported stellar models, an expanded set of tutorials, and the awesome logo made by @hrwakeford. The citation page will still need to be updated post release.

@DavoGrant DavoGrant self-assigned this Nov 29, 2022
@DavoGrant DavoGrant added enhancement New feature or request code-expansion and removed enhancement New feature or request labels Nov 29, 2022
Copy link
Member

@hrwakeford hrwakeford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested out each of the notebooks and they work well.

  • tests were performed using MPS1 and Kurucz (1D)
    I made a comparison between the "nearest" and "trilinear" grid selection criteria for M_H=0.01, Teff=5512, logg=4.47, ld_model="mps1"
    finding the following difference in values

Screenshot 2022-12-08 at 12 07 04

  • the min mu value has the desired effect but note should be made of the limits of this, for example when using mu values over 0.5 it is recommended to also calculate the uncertainty as this will increase them on the values computed.

Suggestion:
change the default to MPS2 with a link to the paper in the documents
Reason: the most up to date values for stellar abundances and mixing relations.

Before package is complete
This pull request is a major milestone to V3 but a number of things need to be completed before this is packaged and releases.

  • Zenodo data archive needs to be updates
  • citation file needs to be updated and clear with examples of statements when using various grids
  • link needs to be updated on the exo-tic.github.io page to the ExoTiC-LD read the docs.
  • testing will need to be completed on the pip installable package and with other packages that have ExoTiC-LD as a dependency

@DavoGrant DavoGrant merged commit 6ec634c into Exo-TiC:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants