-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add actor token interpolation for comments #2
feat: add actor token interpolation for comments #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
owner: "WayneFoundation", | ||
repo: "batcave", | ||
issue_number: issueNumber, | ||
body: "Houston, this is Conflict Lord Bot. We have a conflict. I repeat, we have a conflict. @brucewayne please rebase. Acknowledge.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't leave me hanging man, did he rebase it in the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/brucewayne will love this if we opensource hydra 🤣 (but please keep it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what a shame that such a prestigious handle is wasted on a completely inactive account...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Summary
The code of this action was (and still is in large parts) quite filthy. I extracted and cleaned up a few things that I touched to at least achieve a little bit of structure.
Main goal of this PR is to enable token interpolation in comment strings provided to the action. So far
<%= author %>
is supported. Example usage:Testplan
Successfully tested in https://github.com/ExodusMovement/lerna-version-selectively/pull/135 by setting ref of the action to checkout this repo to this PR's branch (
sparten11740/feat/add-placeholder-interpolation-to-messages
)Further comments
dist/index.js
. No need to review the file.