cleanup: drop setCert / setTransportSecurity API #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
force-pushed
the
chalker/no-certs
branch
from
c1fe66d
to
a28e9f1
Compare
ChALkeR
changed the title
ChALkeR
force-pushed
the
chalker/no-certs
branch
from
a28e9f1
to
3dada84
Compare
feri42
approved these changes
Dec 23, 2021
feri42
requested changes
Dec 23, 2021
There was a problem hiding this comment.
nACK - verified that this breaks server-side:
"Error: (BUG) keyToProtobuf: unsupported key type: PublicKey\n at keyToProtobuf (/home/feri/Work/Exodus/Hedera/hedera-account-faucet/node_modules/@exodus/hashgraph-sdk/lib/cryptography/protobuf.cjs:49:9)\n at AccountCreateTransaction._makeTransactionData (/home/feri/Work/Exodus/Hedera/hedera-account-faucet/node_modules/@exodus/hashgraph-sdk/lib/account/AccountCreateTransaction.cjs:175:60)\n at AccountCreateTransaction._makeTransactionBody (/home/feri/Work/Exodus/Hedera/hedera-account-faucet/node_modules/@exodus/hashgraph-sdk/lib/transaction/Transaction.cjs:632:46)\n at AccountCreateTransaction._makeSignedTransaction (/home/feri/Work/Exodus/Hedera/hedera-account-faucet/node_modules/@exodus/hashgraph-sdk/lib/transaction/Transaction.cjs:618:23)\n at /home/feri/Work/Exodus/Hedera/hedera-account-faucet/node_modules/@exodus/hashgraph-sdk/lib/transaction/Transaction.cjs:410:65\n at Array.map (<anonymous>)\n at AccountCreateTransaction.freezeWith (/home/feri/Work/Exodus/Hedera/hedera-account-faucet/node_modules/@exodus/hashgraph-sdk/lib/transaction/Transaction.cjs:410:46)\n at AccountCreateTransaction.freeze (/home/feri/Work/Exodus/Hedera/hedera-account-faucet/node_modules/@exodus/hashgraph-sdk/lib/transaction/Transaction.cjs:374:17)\n at buildTx (/home/feri/Work/Exodus/Hedera/hedera-account-faucet/packages/hedera-account-faucet/lib/node_modules/@exodus/hedera-lib/src/prepare-tx.js:27:20)\n at HederaAccountFaucet.createAccount (/home/feri/Work/Exodus/Hedera/hedera-account-faucet/packages/hedera-account-faucet/lib/hedera-faucet.js:199:41)","error":{}}}
The error doesn't seem to be cert related though. Not sure if I did something else wrong. But I did verify that I only had one instance of @exodus/hashgraph-sdk and that it was the modified instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
setTransportSecurityAPI from the clients.That allows to drop the embedded certs and minimize the bundle.
That is not called automatically internally, and we don't use it and don't need for the web/rn clients.