Fix logger deprecation warnings #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`warn()` is deprecated and needs to be substituted with `warning()`. This commit fixes this issue.
|
Thanks ! This is going in the right direction, but I would like to fix the broken test before merging. Hopefully it won't take too long. |
MatthieuDartiailh
approved these changes
Oct 30, 2018
Replacing getargspec by getfullargspec fix the issue and does not require any other change.
Also consolidate tests, and prevent the use of too many file descriptors to allow the tests to run on OSX.
|
I took the liberty to push changes fixing the broken test and the other warning from pytest. I will merge once Travis comes back green. |
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 157 157
Lines 12335 12335
=======================================
Hits 12136 12136
Misses 199 199 |
|
Closes #159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warn()is deprecated and needs to be substituted withwarning().This commit fixes this issue. Hope this helps to resolve part of #159. If you want anything to be changed I would be happy to update and resubmit this pull request.