Allow setting hive conf which doesn't have a hivevar #39
Conversation
| @@ -101,6 +101,10 @@ void setHiveVar(HiveConf.ConfVars variable, String value) { | |||
| conf.setVar(variable, value); | |||
| } | |||
|
|
|||
| void setHiveConf(String variable, String value) { | |||
There was a problem hiding this comment.
OK, so this allows one to set arbitrary String values in the HiveConf as opposed to only the ones that Hive itself exposes via HiveConf.ConfVars. It looks like a reasonable addition to me and I can see how this could be useful. Could you please add a simple unit test for this along the lines of https://github.com/HotelsDotCom/beeju/blob/master/src/test/java/com/hotels/beeju/core/BeejuCoreTest.java#L75?
There was a problem hiding this comment.
Good call, I made the changes.
There was a problem hiding this comment.
Looks good thanks for the contribution! If @massdosage approves as well, we'll sort out a release.
|
Thanks for your contribution, we'll try get a release out in the next day or two. |
|
Thank you @massdosage and @patduin for the quick turn around on the PR. I love this library, has been very handy in testing our internal metastore plugins. |
|
@amalakar FYI just release BeeJu 3.1.0 should be propagating to maven central in a few moments. |
We use this library to test metastore audit logger plugin we use. The plugin uses configurations like http url of ingestion service etc. As of now there is no ability to set
HiveConf.ConfVarsinBeejuCore. This adds the ability to set custom configuration keys by string in hive conf object.