[MAJOR] Update to R4j 1.1.0, and implement Retries #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eocantu
reviewed
Oct 28, 2019
| @@ -6,7 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/). | |||
|
|
|||
| ## [Unreleased] | |||
| ### Changed | |||
| - nothing yet | |||
| - Added support for R4j `Retry` | |||
There was a problem hiding this comment.
Can this be moved to an ### Added section?
| builder.enableAutomaticTransitionFromOpenToHalfOpen(); | ||
| } | ||
| @JsonProperty | ||
| private Class[] ignoreExceptions = new Class[0]; |
There was a problem hiding this comment.
Can we match the signature from resilience4j? (i.e. Class<? extends Throwable>[])
The same for the property below.
| * Names of exceptions to ignore | ||
| */ | ||
| @JsonProperty | ||
| private Class[] ignoreExceptions = null; |
There was a problem hiding this comment.
Here and below are other spots where they could be Class<? extends Throwable>[].
There was a problem hiding this comment.
done for all Class[]
added 2 commits
October 28, 2019 08:13
eocantu
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started out trying to implement support for R4j's
Retryfeature, which is in here. But I also bumped us up to Resilience4j v1.1.0, which is a pretty major change from the previous version. Therefore this is a breaking change from the previous version.Added
Retryfeature.Changed
README.MDDeleted
PR Checklist Forms
CHANGELOG.md updated
Unit test(s) added
Reviewer assigned
PR assigned (presumably to submitter)
Labels added (enhancement, bug, documentation)