Skip to content

Commit

Permalink
Merge pull request #109 from ExpediaGroup/merge_from_feast_test
Browse files Browse the repository at this point in the history
fix: Bytewax engine create configmap from object (feast-dev#3821)
  • Loading branch information
EXPEbdodla committed Jun 11, 2024
2 parents 3a6e0c9 + c8f7887 commit 8825afc
Showing 1 changed file with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from feast.infra.registry.base_registry import BaseRegistry
from feast.repo_config import FeastConfigBaseModel
from feast.stream_feature_view import StreamFeatureView
from feast.utils import _get_column_names, get_default_yaml_file_path
from feast.utils import _get_column_names

from .bytewax_materialization_job import BytewaxMaterializationJob

Expand Down Expand Up @@ -187,10 +187,7 @@ def _create_kubernetes_job(self, job_id, paths, feature_view):
def _create_configuration_map(self, job_id, paths, feature_view, namespace):
"""Create a Kubernetes configmap for this job"""

repo_path = self.repo_config.repo_path
assert repo_path
feature_store_path = get_default_yaml_file_path(repo_path)
feature_store_configuration = feature_store_path.read_text()
feature_store_configuration = yaml.dump(self.repo_config.dict())

materialization_config = yaml.dump(
{"paths": paths, "feature_view": feature_view.name}
Expand Down

0 comments on commit 8825afc

Please sign in to comment.