Schema pruning update #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… typeDefs types supported to include GraphQLSchema.
brianjquinn
reviewed
May 18, 2022
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| const Test = require('tape'); | |||
| const gql = require('graphql-tag'); | |||
| const { SchemaDirectiveVisitor } = require('@graphql-tools/utils'); | |||
| const { SchemaDirectiveVisitor } = require('graphql-tools'); | |||
There was a problem hiding this comment.
i could be wrong but don't they recommend using the more specific graphql-tools packages instead of the top level graphql-tools package?
There was a problem hiding this comment.
+1 Is this to avoid breaking change of the graphql-component as the the version @graphql-tools/utils": "^8.6.10 does not have the SchemaDirectiveVisitor?
There was a problem hiding this comment.
Yes but I didn't want to do the full migration yet. We've historically used this older package and a lot of breaking changes in newer packages (like schema directive visitor stuff).
roymanas
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes updated to TS definitions