Skip to content

feat: kotlinx serialization for GraphQLServerRequest -- cherry pick (… #574

feat: kotlinx serialization for GraphQLServerRequest -- cherry pick (…

feat: kotlinx serialization for GraphQLServerRequest -- cherry pick (… #574

Triggered via push April 1, 2024 23:27
Status Success
Total duration 15m 54s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 2 warnings
release-notes
Resource not accessible by integration { name: 'HttpError', id: '8515064006', status: 403, response: { url: 'https://api.github.com/repos/ExpediaGroup/graphql-kotlin/releases', status: 403, headers: { 'access-control-allow-origin': '*', 'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset', connection: 'close', 'content-encoding': 'gzip', 'content-security-policy': "default-src 'none'", 'content-type': 'application/json; charset=utf-8', date: 'Mon, 01 Apr 2024 23:27:22 GMT', 'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin', server: 'GitHub.com', 'strict-transport-security': 'max-age=31536000; includeSubdomains; preload', 'transfer-encoding': 'chunked', vary: 'Accept-Encoding, Accept, X-Requested-With', 'x-accepted-github-permissions': 'contents=write; contents=write,workflows=write', 'x-content-type-options': 'nosniff', 'x-frame-options': 'deny', 'x-github-api-version-selected': '2022-11-28', 'x-github-media-type': 'github.v3; format=json', 'x-github-request-id': 'DD46:594C:3C148A:5E26F4:660B42DA', 'x-ratelimit-limit': '5000', 'x-ratelimit-remaining': '4995', 'x-ratelimit-reset': '1712017639', 'x-ratelimit-resource': 'core', 'x-ratelimit-used': '5', 'x-xss-protection': '0' }, data: { message: 'Resource not accessible by integration', documentation_url: 'https://docs.github.com/rest/releases/releases#create-a-release' } }, request: { method: 'POST', url: 'https://api.github.com/repos/ExpediaGroup/graphql-kotlin/releases', headers: { accept: 'application/vnd.github.v3+json', 'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/16.20.2 (linux; x64)', authorization: 'token [REDACTED]', 'content-type': 'application/json; charset=utf-8' }, body: '{"target_commitish":"refs/heads/6.x.x","name":"7.0.3","tag_name":"7.0.3","body":"## Other Changes\\n\\n- feat: kotlinx serialization for GraphQLServerRequest -- cherry pick (#1937) (#1944) @samuelAndalon\\n- feat: pass ExecutionInput to getOrElse method (#1918) (#1919) @samuelAndalon\\n- fix: create MessageDigest when needed (#1908) @samuelAndalon\\n","draft":true,"prerelease":false,"make_latest":"true"}', request: {} }, event: { id: '8515064006', name: 'push', payload: { after: '65aa3f04b54cc2d2e1f3839cf8d8f171c2a74351', base_ref: null, before: '2fb84471386ebc63846fa5532575e1836f32f8ea', commits: [ { author: { email: 'sam_2f@hotmail.com', name: 'Samuel Vazquez', username: 'samuelAndalon' }, committer: { email: 'noreply@github.com', name: 'GitHub', username: 'web-flow' }, distinct: true, id: '65aa3f04b54cc2d2e1f3839cf8d8f171c2a74351', message: 'feat: kotlinx serialization for GraphQLServerRequest -- cherry pick (#1937) (#1944)\n' + '\n' + 'Switch from `jackson` to `kotlinx.serialization` for\r\n' + 'serialization/deserialization of `GraphQLServerRequest` types.\r\n' + '\r\n' + 'After running benchmarks we where able to identify that deserializing\r\n' + '`GraphQLServerRequest` with `kotlinx.serialization` is quite faster than\r\n' + 'doing it with `jackson`, the reason ? possibly because jackson relies on\r\n' + 'reflections to identify deserialization process.\r\n' + '\r\n' + 'On the other hand, serialization/deserialization of\r\n' + '`GraphQLServerReponse` type is still faster if done with `jackson`,\r\n' + 'possibly becaus
release-notes
HttpError: Resource not accessible by integration at /home/runner/work/_actions/release-drafter/release-drafter/v5/dist/index.js:8462:21 at processTicksAndRejections (node:internal/process/task_queues:96:5) at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v5/dist/index.js:30793:18) { name: 'AggregateError', event: { id: '8515064006', name: 'push', payload: { after: '65aa3f04b54cc2d2e1f3839cf8d8f171c2a74351', base_ref: null, before: '2fb84471386ebc63846fa5532575e1836f32f8ea', commits: [ { author: { email: 'sam_2f@hotmail.com', name: 'Samuel Vazquez', username: 'samuelAndalon' }, committer: { email: 'noreply@github.com', name: 'GitHub', username: 'web-flow' }, distinct: true, id: '65aa3f04b54cc2d2e1f3839cf8d8f171c2a74351', message: 'feat: kotlinx serialization for GraphQLServerRequest -- cherry pick (#1937) (#1944)\n' + '\n' + 'Switch from `jackson` to `kotlinx.serialization` for\r\n' + 'serialization/deserialization of `GraphQLServerRequest` types.\r\n' + '\r\n' + 'After running benchmarks we where able to identify that deserializing\r\n' + '`GraphQLServerRequest` with `kotlinx.serialization` is quite faster than\r\n' + 'doing it with `jackson`, the reason ? possibly because jackson relies on\r\n' + 'reflections to identify deserialization process.\r\n' + '\r\n' + 'On the other hand, serialization/deserialization of\r\n' + '`GraphQLServerReponse` type is still faster if done with `jackson`,\r\n' + 'possibly because of how `kotlinx.serialization` library was designed and\r\n' + 'the poor support for serializing `Any` type:\r\n' + 'https://github.com/Kotlin/kotlinx.serialization/issues/296, which causes\r\n' + 'a lot of memory comsumption.\r\n' + '\r\n' + 'As part of this PR also including the benchmarks. For that, i created a\r\n' + 'separate set of types that are marked with both `jackson` and\r\n' + '`kotlinx.serialization` annotations.\r\n' + '\r\n' + 'Benchmarks results:\r\n' + 'Executed on a MacBookPro 2.6 GHz 6-Core Intel Core i7.\r\n' + '\r\n' + '`GraphQLBatchRequest`\r\n' + '4 batched operations, each operation is aprox: 30kb <img width="1260"\r\n' + 'alt="image"\r\n' + '\r\n' + 'src="https://github.com/ExpediaGroup/graphql-kotlin/assets/6611331/06e5b218-a35e-4baa-a25e-2be1b3c27a95">\r\n' + '\r\n' + '`GraphQLRequest`\r\n' + '<img width="1231" alt="image"\r\n' + '\r\n' + 'src="https://github.com/ExpediaGroup/graphql-kotlin/assets/6611331/e5ecba01-fd41-4872-b3e8-5519414cc918">\r\n' + '\r\n' + '`GraphQLBatchResponse`\r\n' + '<img width="1240" alt="image"\r\n' + '\r\n' + 'src="https://github.com/ExpediaGroup/graphql-kotlin/assets/6611331/ee84bfa4-d7d1-46b4-b4a8-b3c220998a03">\r\n' + '\r\n' + '`GraphQLResponse`\r\n' + '<img width="1197" alt="image"\r\n' + '\r\n' + 'src="https://github.com/ExpediaGroup/graphql-kotlin/assets/6611331/c217e05f-45fc-460e-a059-7667975ee49f">\r\n' + '\r\n' + '### :pencil: Description\r\n' + '\r\n' + '\r\n' + '### :link: Related Issues', timestamp: '2024-04-01T16:27:09-07:00', tree_id: '83415dcd8bf65da1f8d0fc487a9e2128e663f50c', url: 'https://github.com/ExpediaGroup/graphql-kotlin/commit/65aa3f04b54cc2d2e1f3839cf8d8f171c2a74351' } ], compare: 'https://github.com/ExpediaGroup/graphql-kotlin/compare/2fb84471386e...65aa3f04b54c', crea
release-notes
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: release-drafter/release-drafter@v5. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, gradle/wrapper-validation-action@v1, actions/setup-java@v3, gradle/gradle-build-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.