[generator] avoid duplicate argument deserialization #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2022
Closed
dariuszkuc
added
changes: major
added 2 commits
February 27, 2022 12:57
Closed
smyrick
reviewed
Mar 4, 2022
.../kotlin/com/expediagroup/graphql/generator/exceptions/CouldNotConstructAValidKotlinObject.kt
Outdated
Show resolved
Hide resolved
smyrick
reviewed
Mar 4, 2022
samuelAndalon
approved these changes
Mar 8, 2022
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Apr 26, 2022
With the refactoring of our argument parsing logic (ExpediaGroup#1379) we dropped the support for the arrays. This had a side effect that directives could no longer be declared as accepting a list of arguments. Adding back support of arrays/varargs just for the directives. Resolved: ExpediaGroup#1404
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Apr 26, 2022
With the refactoring of our argument parsing logic (ExpediaGroup#1379) we dropped the support for the arrays. This had a side effect that directives could no longer be declared as accepting a list of arguments. Adding back support of arrays/varargs just for the directives. Resolves: ExpediaGroup#1404
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Update function data fetcher argument parsing logic to no longer depend on Jackson. Current logic is problematic as arguments passed to data fetchers are already coerced to appropriate type by
graphql-javaand Jackson is unaware of it leading to duplicate deserialization. This leads to custom scalar inputs deserialization problems.Instead of relying on Jackson, argument mapping logic is updated to rely on reflection to instantiate objects based on their primary constructor.
NOTE: this change removes dependency on Jackson from
graphql-kotlin-schema-generator.graphql-kotlin-serveris still tied to Jackson for execution.Breaking changes:
FunctionDataFetcherno longer accepts JacksonObjectMapperas an argument🔗 Related Issues