Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mark ExecutionResult and Throwable as nullable #1521

Merged
merged 1 commit into from
Aug 18, 2022
Merged

feat: mark ExecutionResult and Throwable as nullable #1521

merged 1 commit into from
Aug 18, 2022

Conversation

samuelAndalon
Copy link
Contributor

📝 Description

both result and exception (t) can be null depending on the execution result

this could cause some noise of implementation using this instrumentation

@samuelAndalon samuelAndalon added changes: patch Changes require a patch version module: executions issue affects the executions code labels Aug 18, 2022
@samuelAndalon samuelAndalon changed the title feat: mark execution result and Throwable as nullable feat: mark executionResult and Throwable as nullable Aug 18, 2022
@samuelAndalon samuelAndalon changed the title feat: mark executionResult and Throwable as nullable feat: mark ExecutionResult and Throwable as nullable Aug 18, 2022
@samuelAndalon samuelAndalon merged commit 1169175 into ExpediaGroup:master Aug 18, 2022
@samuelAndalon samuelAndalon deleted the feat/nullable-instrumentation-context branch August 18, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapaderster tapaderster tapaderster approved these changes

@ameerabdul ameerabdul ameerabdul approved these changes

Assignees
No one assigned
Labels
changes: patch Changes require a patch version module: executions issue affects the executions code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuelAndalon @tapaderster @ameerabdul