fix(federation): skip fieldset validation when it includes type reference #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence We are performing federated directive validations when generating GraphQL schema. This is an extra convenience as it gives us information about invalid schema sooner. Subgraph schemas will then be re-validated during the supergraph composition logic. Currently it is possible to create `@key` that references the type still under construction (`GraphQLReferenceType`). Since we cannot validate fields on the type that doesn't exist yet, we cannot validate it either. Updating logic to log a warning when this happens and skip validation logic.
samuelAndalon
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
We are performing federated directive validations when generating GraphQL schema. This is an extra convenience as it gives us information about invalid schema sooner. Subgraph schemas will then be re-validated during the supergraph composition logic.
Currently it is possible to create
@keythat references the type still under construction (GraphQLReferenceType). Since we cannot validate fields on the type that doesn't exist yet, we cannot validate it either. Updating logic to log a warning when this happens and skip validation logic.🔗 Related Issues
Resolves: #1858