Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update dependencies #1974

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

reneleonhardt
Copy link
Contributor

@reneleonhardt reneleonhardt commented May 25, 2024

Updates

  • Kotlin 1.8.22 to 1.9.24
  • android-plugin 8.1.1 to 8.5.0
  • classgraph 4.8.170 to 4.8.174
  • compile-testing 0.3.2 to 0.5.0
  • detekt 1.23.0 to 1.23.6
  • dokka 1.8.20 to 1.9.20
  • federation 4.4.1 to 5.1.0
  • graalvm 0.10.1 to 0.10.2
  • Gradle Wrapper (latest, no version shown)
  • icu 74.2 to 75.2
  • jackson 2.15.4 to 2.17.1
  • kotlinx-benchmark 0.4.8 to 0.4.11
  • kotlinx-coroutines 1.7.3 to 1.8.1
  • kotlinx-serialization 1.5.1 to 1.6.3 (3 test cases failing in GenerateKotlinxClientIT)
  • ktlint-core 0.45.2 to 1.2.1 (many rules had to be disabled, reformat required)
  • ktlint-plugin 10.3.0 to 12.1.1
  • ktor 2.3.10 to 2.3.11
  • logback 1.5.4 to 1.5.6
  • maven-plugin-annotation 3.12.0 to 3.13.1
  • mockk 1.13.7 to 1.3.11
  • nexus-publish-plugin 1.3.0 to 2.0.0
  • poet 1.14.2 to 1.17.0
  • reactor-core 3.5.15 to 3.6.7
  • slf4j 2.0.12 to 2.0.13
  • spring 6.0.18 to 6.1.10
  • spring-boot 3.1.10 to 3.3.1
  • wiremock 3.5.2 to 3.6.0

Added

  • spring-context (was needed for spring-web in graphql-kotlin-spring-client)

Improvements

  • Let Dependabot update GitHub Actions

TODO

  • Fix GraphQLTestUtils and GenerateKotlinxClientIT after Kotlin 1.9 upgrade
  • Remove disabled rules in .editorconfig, then ./gradlew ktlintFormat

.github/dependabot.yml Outdated Show resolved Hide resolved
@dariuszkuc
Copy link
Collaborator

nit: we probably don't need to pin the coverage values to the exact ones, i.e. we should have some wiggle room when making some trivial changes

@dariuszkuc
Copy link
Collaborator

Thanks for the PR!

@@ -10,6 +10,7 @@ dependencies {
api(projects.graphqlKotlinClientJackson)
api(libs.kotlinx.coroutines.reactor)
api(libs.spring.webflux)
api(libs.spring.context)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need explicit spring context dependency here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spring changed their dependency management I guess 🤷

:graphql-kotlin-spring-client:compileTestKotlin

Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
class org.springframework.http.client.reactive.ReactorClientHttpConnector, unresolved supertypes: org.springframework.context.SmartLifecycle

@reneleonhardt
Copy link
Contributor Author

nit: we probably don't need to pin the coverage values to the exact ones, i.e. we should have some wiggle room when making some trivial changes

I reverted the new values except where the difference was too big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants