Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage in the main README #343

Merged
merged 3 commits into from Sep 13, 2019
Merged

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Sep 12, 2019

馃摑 Description

Add some more details in the main README to align with the Expedia Group OSS templates and provide some more details to first time viewers. Also update the CONTRIBUTING doc with more details

馃敆 Related Issues

https://github.com/ExpediaGroup/new-project

Add some more details in the main README to align with the Expedia Group OSS templates and provide some more details to first time viewers. Also update the CONTRIBUTING doc with more details
@smyrick smyrick added the type: documentation Documentation or test changes label Sep 12, 2019
@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #343 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #343   +/-   ##
=========================================
  Coverage     96.82%   96.82%           
  Complexity      278      278           
=========================================
  Files            81       81           
  Lines           976      976           
  Branches        180      180           
=========================================
  Hits            945      945           
  Misses            6        6           
  Partials         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 370d650...eaed520. Read the comment docs.

README.md Outdated Show resolved Hide resolved
@kevinrc
Copy link

kevinrc commented Sep 13, 2019

馃憤 This looks good! thanks for updating!

@dariuszkuc dariuszkuc merged commit 32adfe9 into ExpediaGroup:master Sep 13, 2019
@smyrick smyrick deleted the readme-contrib branch September 13, 2019 16:37
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Add some more details in the main README to align with the Expedia Group OSS templates and provide some more details to first time viewers. Also update the CONTRIBUTING doc with more details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Documentation or test changes
Development

Successfully merging this pull request may close these issues.

None yet

4 participants