BREAKING CHANGE: Change GraphQLID to only use strings #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ExpediaGroup#317 Due to deserliazation issues that can happen with UUID, we are only going to support Strings as the explicit type for GraphQLID. You can still use UUID in your data fetchers but you will have to do the parsing yourself and handle the exceptions if it is not a valid UUID.
smyrick
added
type: enhancement
dariuszkuc
reviewed
Sep 17, 2019
...n-schema-generator/src/test/kotlin/com/expediagroup/graphql/generator/SchemaGeneratorTest.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
approved these changes
Sep 17, 2019
|
Example of error that can happen with current implementation #317 (comment) |
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
============================================
- Coverage 96.83% 96.82% -0.01%
Complexity 275 275
============================================
Files 82 82
Lines 980 977 -3
Branches 182 182
============================================
- Hits 949 946 -3
Misses 6 6
Partials 25 25
Continue to review full report at Codecov.
|
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Change GraphQLID to only use strings Fixes ExpediaGroup#317 Due to deserliazation issues that can happen with UUID, we are only going to support Strings as the explicit type for GraphQLID. You can still use UUID in your data fetchers but you will have to do the parsing yourself and handle the exceptions if it is not a valid UUID. * Drop extra id fields * Fix unit testS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
Due to deserialization issues that can happen with UUID, we are only going to support Strings as the explicit type for GraphQLID. You can still use UUID in your data fetchers but you will have to do the parsing yourself and handle the exceptions if it is not a valid UUID.
Example of client input
馃敆 Related Issues
Fixes #317