Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spring-server] update to use Spring Boot RC1 #421

Merged
merged 1 commit into from Oct 4, 2019
Merged

[spring-server] update to use Spring Boot RC1 #421

merged 1 commit into from Oct 4, 2019

Conversation

dariuszkuc
Copy link
Collaborator

No description provided.

@dariuszkuc dariuszkuc added changes: patch Changes require a patch version type: dependency changes Dependency change which doesn't affect our library usage labels Oct 3, 2019
@codecov-io
Copy link

codecov-io commented Oct 3, 2019 •
edited

Codecov Report

Merging #421 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #421   +/-   ##
========================================
  Coverage      97.8%   97.8%           
  Complexity      325     325           
========================================
  Files           105     105           
  Lines          1228    1228           
  Branches        202     202           
========================================
  Hits           1201    1201           
  Misses            7       7           
  Partials         20      20
Impacted Files Coverage Δ Complexity Δ
...roup/graphql/spring/PlaygroundAutoConfiguration.kt 75% <0%> (ø) 2 <0> (ø) ⬇️
...expediagroup/graphql/spring/RoutesConfiguration.kt 100% <100%> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8b4a6...837b4c4. Read the comment docs.

@dariuszkuc dariuszkuc added changes: minor Changes require a minor version and removed changes: patch Changes require a patch version labels Oct 4, 2019
@dariuszkuc
Copy link
Collaborator Author

Changing to minor version change as there was a breaking change in router functions between SpringBoot M6 and RC1 (bodyAndAwait -> bodyValueAndAwait)

@dariuszkuc dariuszkuc merged commit 4d51b9a into ExpediaGroup:master Oct 4, 2019
@dariuszkuc dariuszkuc deleted the boot_rc1 branch October 4, 2019 14:20
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
@dariuszkuc
[spring-server] update to use Spring Boot RC1 (ExpediaGroup#421)
32867be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gscheibel gscheibel gscheibel approved these changes

Assignees
No one assigned
Labels
changes: minor Changes require a minor version type: dependency changes Dependency change which doesn't affect our library usage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dariuszkuc @codecov-io @gscheibel