Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move spring-boot version to single location #431

Merged
merged 4 commits into from Oct 16, 2019

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Oct 16, 2019

馃摑 Description

Move the declared version of spring-boot to the root so we use the same version across all the modules and examples

馃敆 Related Issues

Fixes #429

Shane Myrick added 2 commits October 16, 2019 10:16
Move the declared verion of spring-boot to the root so we use the same version across all the modules and examples
@smyrick smyrick added type: bug Something isn't working changes: patch Changes require a patch version labels Oct 16, 2019
@codecov-io
Copy link

codecov-io commented Oct 16, 2019

Codecov Report

Merging #431 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #431   +/-   ##
========================================
  Coverage      97.8%   97.8%           
  Complexity      325     325           
========================================
  Files           105     105           
  Lines          1230    1230           
  Branches        202     202           
========================================
  Hits           1203    1203           
  Misses            7       7           
  Partials         20      20

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d6e5718...6cd8288. Read the comment docs.

@smyrick smyrick merged commit b0bdf1f into ExpediaGroup:master Oct 16, 2019
@smyrick smyrick deleted the spring-boot-version branch October 16, 2019 20:13
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* Move spring-boot version to single location

Move the declared verion of spring-boot to the root so we use the same version across all the modules and examples

* Update README docs

* Update parent/child for the examples

* Update maven settings for root directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: patch Changes require a patch version type: bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Spring Sample: Could not find artifact com.expediagroup:graphql-kotlin-spring-server:jar:1.1.1-SNAPSHOT
3 participants