Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spring-server] simplify schema configuration auto configuration #433

Merged
merged 1 commit into from Oct 16, 2019

Conversation

dariuszkuc
Copy link
Collaborator

📝 Description

SchemaGeneratorConfig/FederatedSchemaGeneratorConfig auto config beans now accept optional parameters to set custom hooks, data fetcher factory provider and top level names.

`SchemaGeneratorConfig`/`FederatedSchemaGeneratorConfig` auto config beans now accept optional parameters to set custom hooks, data fetcher factory provider and top level names.
@smyrick smyrick added changes: minor Changes require a minor version type: enhancement New feature or request labels Oct 16, 2019
@codecov-io
Copy link

codecov-io commented Oct 16, 2019

Codecov Report

Merging #433 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #433      +/-   ##
============================================
+ Coverage     97.74%   97.75%   +0.01%     
- Complexity      326      327       +1     
============================================
  Files           106      106              
  Lines          1242     1248       +6     
  Branches        207      207              
============================================
+ Hits           1214     1220       +6     
  Misses            7        7              
  Partials         21       21
Impacted Files Coverage Δ Complexity Δ
.../com/expediagroup/graphql/SchemaGeneratorConfig.kt 100% <100%> (ø) 5 <1> (ø) ⬇️
...roup/graphql/spring/FederationAutoConfiguration.kt 100% <100%> (ø) 5 <2> (+1) ⬆️
...diagroup/graphql/hooks/NoopSchemaGeneratorHooks.kt 100% <100%> (ø) 1 <1> (ø) ⬇️
...diagroup/graphql/spring/SchemaAutoConfiguration.kt 90% <100%> (+1.76%) 3 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab2acff...46c9c12. Read the comment docs.

@dariuszkuc dariuszkuc merged commit 71900a6 into ExpediaGroup:master Oct 16, 2019
@dariuszkuc dariuszkuc deleted the autoconfig branch October 16, 2019 22:18
@dariuszkuc dariuszkuc added changes: patch Changes require a patch version changes: minor Changes require a minor version and removed changes: minor Changes require a minor version changes: patch Changes require a patch version labels Oct 16, 2019
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
…ediaGroup#433)

`SchemaGeneratorConfig`/`FederatedSchemaGeneratorConfig` auto config beans now accept optional parameters to set custom hooks, data fetcher factory provider and top level names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: minor Changes require a minor version type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants