Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update publish-docs to use github tokens" #511

Merged
merged 2 commits into from Dec 9, 2019

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Dec 9, 2019

Reverts #504

We need to use the token of a verified user that has admin access to our repo to publish to Github Pages

So we can not use the auto token for Actions, we are going back to using @eg-oss-ci

https://help.github.com/en/github/working-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#troubleshooting-publishing-problems-with-your-github-pages-site

@smyrick smyrick added type: bug Something isn't working type: tool update CI, code coverage, or linter updates labels Dec 9, 2019
@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #511 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #511   +/-   ##
========================================
  Coverage      97.9%   97.9%           
  Complexity      335     335           
========================================
  Files           106     106           
  Lines          1290    1290           
  Branches        207     207           
========================================
  Hits           1263    1263           
  Misses            7       7           
  Partials         20      20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b387839...dbf4ec5. Read the comment docs.

@smyrick smyrick merged commit f1b69fc into master Dec 9, 2019
@smyrick smyrick deleted the revert-504-smyrick-patch-1 branch December 9, 2019 22:48
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* Revert "Update publish-docs.yml (ExpediaGroup#504)"

This reverts commit 353566c.

* Use token for EG CI bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: tool update CI, code coverage, or linter updates
Development

Successfully merging this pull request may close these issues.

None yet

2 participants