Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support List for input arguments #546

Merged
merged 4 commits into from
Jan 14, 2020
Merged

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Jan 13, 2020

📝 Description

Adds support for using List<*> as the type for function arguments instead of the concrete class ArrayList or arrays

🔗 Related Issues

Fixes #509

@smyrick smyrick added type: enhancement New feature or request changes: minor Changes require a minor version labels Jan 13, 2020
Fixes ExpediaGroup#509

Adds support for using List<*> as the type for function arguments instead of the concrete class ArrayList or arrays
Shane Myrick added 3 commits January 13, 2020 15:29
We don't cache values in the generateUnion method anymore so we don't need to validate the cache there
@dariuszkuc dariuszkuc merged commit 18a5f9b into ExpediaGroup:master Jan 14, 2020
@smyrick smyrick deleted the list-input branch January 14, 2020 17:03
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* Support List for input arguments

Fixes ExpediaGroup#509

Adds support for using List<*> as the type for function arguments instead of the concrete class ArrayList or arrays

* Remove unused unit test

We don't cache values in the generateUnion method anymore so we don't need to validate the cache there

* Remove unused exception:

* Update unit tests for coverage levels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: minor Changes require a minor version type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Support List for input types
2 participants