Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Gradle wrapper memory #624

Merged
merged 3 commits into from Feb 29, 2020

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Feb 27, 2020

馃摑 Description

Increase the gradle jvm max memory as we are seeing intermittent OutOfMemory errors on GitHub Actions

See: gradle/gradle#8139

馃敆 Related Issues

N\A

Shane Myrick added 2 commits February 27, 2020 11:45
Increase the gradle jvm max memory as we are seeing intermittent OutOfMemory errors on GitHub Actions
@smyrick smyrick added the type: tool update CI, code coverage, or linter updates label Feb 27, 2020
@smyrick smyrick changed the title Gradle wrapper memory Increase Gradle wrapper memory Feb 27, 2020
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.2-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.2.1-bin.zip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update the wrapper binary as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran ./gradlew wrapper and that did not change the jar or the executables

Copy link
Collaborator

@dariuszkuc dariuszkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to update GH action configurations? i.e. unsure what are their defaults

@smyrick
Copy link
Contributor Author

smyrick commented Feb 29, 2020

I don't think there are configurations for changing the runners

It looks like they all have the same resources

https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners#supported-runners-and-hardware-resources

@dariuszkuc dariuszkuc merged commit 326f6dd into ExpediaGroup:master Feb 29, 2020
@smyrick smyrick deleted the gradle-wrapper-memory branch March 1, 2020 16:19
@smyrick
Copy link
Contributor Author

smyrick commented Mar 1, 2020

And it still failed

DirectiveTests > SchemaGenerator marks deprecated queries and documents replacement() FAILED
    io.github.classgraph.ClassGraphException at DirectiveTests.kt:49
        Caused by: java.lang.OutOfMemoryError

332 tests completed, 24 failed, 2 skipped

I don't know if we want to try to increase again. It doesn't look like it is one test in particular running high usage as all the generator tests are just failing

https://github.com/ExpediaGroup/graphql-kotlin/runs/476345306?check_suite_focus=true#step:6:212

dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* Increase gradle memory

Increase the gradle jvm max memory as we are seeing intermittent OutOfMemory errors on GitHub Actions

* Remove incubating features

Co-authored-by: Dariusz Kuc <dariusz_kuc@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: tool update CI, code coverage, or linter updates
Development

Successfully merging this pull request may close these issues.

None yet

2 participants