Support sealed classes for interfaces #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrick
added
type: enhancement
dariuszkuc
reviewed
Mar 21, 2020
dariuszkuc
requested changes
Mar 21, 2020
There was a problem hiding this comment.
Can you update https://github.com/ExpediaGroup/graphql-kotlin/blob/master/examples/spring/src/main/kotlin/com/expediagroup/graphql/examples/query/PolymorphicQuery.kt with example of sealed class?
dariuszkuc
approved these changes
Mar 21, 2020
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Support sealed classes for interfaces * Update docs and examples with more sealed classes Co-authored-by: Shane Myrick <accounts@shanemyrick.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
Allows sealed classes to be used as GraphQL Interfaces. This means that you can restrict the possible implementations of the interfaces since subclasses can only be declared with the root class
https://kotlinlang.org/docs/reference/sealed-classes.html
馃敆 Related Issues
Fixes #642