Remove federated type registry #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrick
added
type: enhancement
huehnerlady
pushed a commit
to huehnerlady/graphql-kotlin
that referenced
this pull request
Oct 16, 2020
* Remove FederatedTypeRegistry * Fix test file * Update docs on type registry Co-authored-by: Shane Myrick <accounts@shanemyrick.com>
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Remove FederatedTypeRegistry * Fix test file * Update docs on type registry Co-authored-by: Shane Myrick <accounts@shanemyrick.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
Now that the typename information is part of the resolvers we can just pass the resolvers around and there is no need to publicly expose the
FederatedTypeRegistrysince it is just a mapping of internal code.Instead we can move this "cache" to the
EntityResolverclass and delete all public usage of the other code. This also removes the possibility of error by forgetting to configure theFederatedTypeRegistrycorrectly馃敆 Related Issues
#851