Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes typo and adds tests for subscription (context) #950

Merged
merged 4 commits into from Nov 30, 2020
Merged

fixes typo and adds tests for subscription (context) #950

merged 4 commits into from Nov 30, 2020

Conversation

gerald24
Copy link
Contributor

@gerald24 gerald24 commented Nov 30, 2020 •
edited by smyrick

📝 Description

Small typo in the subscription code constant and adds an example unit test

🔗 Related Issues

N\A

@gerald24 gerald24 changed the title fixes typo of const in ContextWebFilter fixes typo and adds tests for subscription (context) Nov 30, 2020
@smyrick smyrick added changes: patch Changes require a patch version type: refactor Code changes that have no impact on users module: server Issue affects the server code labels Nov 30, 2020
@smyrick smyrick added changes: major Changes require a major version and removed changes: patch Changes require a patch version labels Nov 30, 2020
@smyrick
Copy link
Contributor

smyrick commented Nov 30, 2020

This is a breaking change since the import is updated. Will have to keep in the 4.x.x release

@smyrick smyrick merged commit 982c311 into ExpediaGroup:master Nov 30, 2020
huehnerlady pushed a commit to huehnerlady/graphql-kotlin that referenced this pull request Apr 27, 2021
@gerald24 @huehnerlady
fixes typo and adds tests for subscription (context) (ExpediaGroup#950)
826f87b 
* fixes typo

* added test for subscriptionContext (using MyGraphQLContext and MySubscriptionHooks)

* removes blank lines

Co-authored-by: Gerald Leeb <gerald24@me.com>
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
@gerald24
fixes typo and adds tests for subscription (context) (ExpediaGroup#950)
ad2223d 
* fixes typo

* added test for subscriptionContext (using MyGraphQLContext and MySubscriptionHooks)

* removes blank lines

Co-authored-by: Gerald Leeb <gerald24@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smyrick smyrick smyrick approved these changes

Assignees
No one assigned
Labels
changes: major Changes require a major version module: server Issue affects the server code type: refactor Code changes that have no impact on users
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gerald24 @smyrick