feat: Add a new search implementation #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all tests passing
add new search, with option to use old one
fix: re-add slop
baumandm
reviewed
Jan 17, 2024
packages/shared/src/search2.ts
Outdated
| 'description', | ||
| 'name^3', | ||
| 'fullName', // (index with simple analyzer?) | ||
| 'tags', |
There was a problem hiding this comment.
I think tags should be boosted to ^2; if the user searches for a tag name, that's a pretty good signal that it's a match, even if they don't use #tag
baumandm
changed the title
baumandm
changed the title
eg-oss-ci
added a commit
that referenced
this pull request
Jan 18, 2024
## [3.26.0](v3.25.23...v3.26.0) (2024-01-18) ### Features * Add a new search implementation ([#1984](#1984)) ([02bd961](02bd961)) ### Bug Fixes * **deps:** bump @emotion/styled from 11.10.6 to 11.11.0 ([913aa38](913aa38)) * **deps:** bump follow-redirects from 1.15.2 to 1.15.4 ([570529f](570529f)) * **deps:** bump pino-http from 8.3.3 to 9.0.0 ([1884681](1884681)) * Fix attachment uploading issue caused by ES2022 spread operator ([87ae1d3](87ae1d3)) * Fix saving new avatars to a user profile ([420e134](420e134))
|
🎉 This PR is included in version 3.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how Elasticsearch queries get made from user queries.
At a high level, it keeps words together to do better than single-word query clauses when possible, more Elasticsearch clauses get generated, and the fields that get searched are restricted to avoid irrelevant matches.
There's also a toggle to the right of the search bar that allows users to revert to using the old search.