-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a new search implementation #1984
Conversation
…all tests passing
add new search, with option to use old one
fix: re-add slop
packages/shared/src/search2.ts
Outdated
'description', | ||
'name^3', | ||
'fullName', // (index with simple analyzer?) | ||
'tags', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think tags
should be boosted to ^2
; if the user searches for a tag name, that's a pretty good signal that it's a match, even if they don't use #tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
## [3.26.0](v3.25.23...v3.26.0) (2024-01-18) ### Features * Add a new search implementation ([#1984](#1984)) ([02bd961](02bd961)) ### Bug Fixes * **deps:** bump @emotion/styled from 11.10.6 to 11.11.0 ([913aa38](913aa38)) * **deps:** bump follow-redirects from 1.15.2 to 1.15.4 ([570529f](570529f)) * **deps:** bump pino-http from 8.3.3 to 9.0.0 ([1884681](1884681)) * Fix attachment uploading issue caused by ES2022 spread operator ([87ae1d3](87ae1d3)) * Fix saving new avatars to a user profile ([420e134](420e134))
🎉 This PR is included in version 3.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR changes how Elasticsearch queries get made from user queries.
At a high level, it keeps words together to do better than single-word query clauses when possible, more Elasticsearch clauses get generated, and the fields that get searched are restricted to avoid irrelevant matches.
There's also a toggle to the right of the search bar that allows users to revert to using the old search.