Jarviz Updates #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasanthak
reviewed
Mar 11, 2021
| * @return true if version is LATEST or RELEASE, false otherwise. | ||
| */ | ||
| @Value.Default | ||
| default boolean isVersionLatestOrRelease() { |
There was a problem hiding this comment.
Since this contain 2, we can keep it as a List, else we can make a it a Set.
lasanthak
reviewed
Mar 11, 2021
| @@ -28,6 +28,8 @@ | |||
| @JsonInclude(value = JsonInclude.Include.NON_EMPTY) | |||
| public interface CouplingRecord { | |||
|
|
|||
lasanthak
reviewed
Mar 11, 2021
| @@ -73,6 +73,52 @@ public void testToFileName() { | |||
| .isEqualTo("foo-bar-2.0.1-SNAPSHOT.jar"); | |||
| } | |||
|
|
|||
| @Test | |||
lasanthak
reviewed
Mar 11, 2021
| @@ -59,4 +60,19 @@ public void testDiscoverArtifact_Fail() throws ArtifactNotFoundException { | |||
| artifactDiscoveryService.discoverArtifact(artifact); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
For this test to be correct shouldn't we remove "throws ArtifactNotFoundException" from the signature?
|
💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
continueOnMavenErrorflag inconfig.json. When set totrue,Jarviswill continue processing remaining applications, fromartifact.json, after it encounters maven errors. Default value isfalse.RELEASEandLATESTas dependency versions inartifact.json.appSetNameis now written to outputjsonlfile.🔗 Related Issues