More log improvements: log navigations, improve logs, flush on logout…

… and app inactive

package.json

@@ -60,7 +60,7 @@
     "electron-log": "^4.3.5",
     "electron-serve": "^1.0.0",
     "electron-updater": "^4.3.4",
-    "expensify-common": "git://github.com/Expensify/expensify-common.git#8e163a9b72c1bd33c83ee5ebef6b7a69ce6f54b4",
+    "expensify-common": "git://github.com/Expensify/expensify-common.git#5ddf00f89e78ab22a50977eb367d4c2805555b93",
     "expo-haptics": "^10.0.0",
     "file-loader": "^6.0.0",
     "html-entities": "^1.3.1",

src/App.js

@@ -1,9 +1,10 @@
-import React from 'react';
-import {LogBox} from 'react-native';
+import React, {Component} from 'react';
+import {AppState, LogBox} from 'react-native';
 import {SafeAreaProvider} from 'react-native-safe-area-context';
 import CustomStatusBar from './components/CustomStatusBar';
 import ErrorBoundary from './components/ErrorBoundary';
 import Expensify from './Expensify';
+import Log from './libs/Log';
 
 LogBox.ignoreLogs([
     // Basically it means that if the app goes in the background and back to foreground on Android,
@@ -15,14 +16,41 @@ LogBox.ignoreLogs([
     'Require cycle: node_modules/rn-fetch-blob',
 ]);
 
-const App = () => (
-    <SafeAreaProvider>
-        <CustomStatusBar />
-        <ErrorBoundary errorMessage="E.cash crash caught by error boundary">
-            <Expensify />
-        </ErrorBoundary>
-    </SafeAreaProvider>
-);
+class App extends Component {
+    constructor(props) {
+        super(props);
+        this.state = {
+            appState: AppState.currentState,
+        };
+        this.handleAppStateChange = this.handleAppStateChange.bind(this);
+    }
+
+    componentDidMount() {
+        AppState.addEventListener('change', this.handleAppStateChange);
+    }
+
+    componentWillUnmount() {
+        AppState.removeEventListener('change', this.handleAppStateChange);
+    }
+
+    handleAppStateChange(nextAppState) {
+        if (nextAppState.match(/inactive|background/) && this.state.appState === 'active') {
+            Log.info('Flushing logs as app is going inactive', true);
+        }
+        this.setState({appState: nextAppState});
+    }
+
+    render() {
+        return (
+            <SafeAreaProvider>
+                <CustomStatusBar />
+                <ErrorBoundary errorMessage="E.cash crash caught by error boundary">
+                    <Expensify />
+                </ErrorBoundary>
+            </SafeAreaProvider>
+        );
+    }
+}
 
 App.displayName = 'App';
 

src/libs/Log.js

@@ -5,6 +5,9 @@ import getPlatform from './getPlatform';
 import {version} from '../../package.json';
 import NetworkConnection from './NetworkConnection';
 
+let timeout = null;
+let info;
+
 /**
  * Network interface for logger.
  *
@@ -19,6 +22,8 @@ function serverLoggingCallback(params) {
     if (requestParams.parameters) {
         requestParams.parameters = JSON.stringify(params.parameters);
     }
+    clearTimeout(timeout);
+    timeout = setTimeout(() => info('Flushing logs older than 10 minutes', true), 10 * 60 * 1000);
     return API.Log(requestParams);
 }
 
@@ -33,6 +38,8 @@ const Log = new Logger({
     },
     isDebug: !CONFIG.IS_IN_PRODUCTION,
 });
+info = Log.info;
+timeout = setTimeout(() => info('Flushing logs older than 10 minutes', true), 10 * 60 * 1000);
 
 NetworkConnection.registerLogInfoCallback(Log.info);
 export default Log;

src/libs/Navigation/Navigation.js

@@ -4,6 +4,7 @@ import {StackActions, DrawerActions} from '@react-navigation/native';
 import PropTypes from 'prop-types';
 import Onyx from 'react-native-onyx';
 import linkTo from './linkTo';
+import Log from '../Log';
 import ROUTES from '../../ROUTES';
 import SCREENS from '../../SCREENS';
 import CustomActions from './CustomActions';
@@ -54,6 +55,7 @@ function goBack(shouldOpenDrawer = true) {
  * @param {String} route
  */
 function navigate(route = ROUTES.HOME) {
+    Log.info('Navigating to route', false, {route});
     if (route === ROUTES.HOME) {
         if (isLoggedIn) {
             openDrawer();

src/libs/PusherConnectionManager.js

@@ -44,7 +44,11 @@ function init() {
                         return;
                     }
 
-                    Log.info('[PusherConnectionManager] Pusher authenticated successfully', false, {channelName: channel.name});
+                    Log.info(
+                        '[PusherConnectionManager] Pusher authenticated successfully',
+                        false,
+                        {channelName: channel.name},
+                    );
                     callback(null, data);
                 })
                 .catch((error) => {

src/libs/actions/Session.js

@@ -5,6 +5,7 @@ import ONYXKEYS from '../../ONYXKEYS';
 import redirectToSignIn from './SignInRedirect';
 import * as API from '../API';
 import CONFIG from '../../CONFIG';
+import Log from '../Log';
 import PushNotification from '../Notification/PushNotification';
 import Timing from './Timing';
 import CONST from '../../CONST';
@@ -61,6 +62,7 @@ function createAccount(login) {
  * Clears the Onyx store and redirects user to the sign in page
  */
 function signOut() {
+    Log.info('Flushing logs before signing out', true);
     if (credentials && credentials.autoGeneratedLogin) {
         // Clean up the login that we created
         API.DeleteLogin({