Skip to content

Commit

Permalink
Merge pull request #7996 from Expensify/Rory-FixDesktopBuild
Browse files Browse the repository at this point in the history
[CP Stg] Add title and artifactName back in ElectronBuilder config

(cherry picked from commit 2a40af5)
  • Loading branch information
AndrewGable authored and OSBotify committed Mar 4, 2022
1 parent f833a22 commit 4f71c95
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const {version} = require('../../package.json');
const {version} = require('../package.json');

const isStaging = process.env.ELECTRON_ENV === 'staging';
const isPublishing = process.argv.includes('--publish');
Expand Down Expand Up @@ -26,6 +26,8 @@ module.exports = {
type: 'distribution',
},
dmg: {
title: 'New Expensify',
artifactName: 'NewExpensify.dmg',
internetEnabled: true,
},
publish: [{
Expand Down
2 changes: 2 additions & 0 deletions desktop/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ const CONFIG = require('../src/CONFIG').default;

const port = process.env.PORT || 8080;

app.setName('New Expensify');

/**
* Electron main process that handles wrapping the web application.
*
Expand Down
2 changes: 1 addition & 1 deletion desktop/notarize.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const {notarize} = require('electron-notarize');
const electron = require('../config/electronBuilder/electronBuilder.config');
const electron = require('../config/electronBuilder.config');

exports.default = function notarizing(context) {
const {electronPlatformName, appOutDir} = context;
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-desktop.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ info ""
title "Building Desktop App Archive Using Electron"
info ""
shift 1
"$LOCAL_PACKAGES/electron-builder" --config config/electronBuilder/electronBuilder.config.js "$@"
"$LOCAL_PACKAGES/electron-builder" --config config/electronBuilder.config.js "$@"

0 comments on commit 4f71c95

Please sign in to comment.